1706398 - Implement "action" API / manifest key

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Rob Wu [:robwu]]

In manifest v3, the browser_action key has been renamed to action (and in Chrome, page_action has been merged with it).

Although we haven't decided whether we're also going to merge page_action, the least that we can do for compatibility is to introduce an action manifest key.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1706398 implement action support and alias browser_action to action.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1706398 support internal command _execute_action

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1706398 support action context type for context menus

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb832bfd3da
implement action support and alias browser_action to action. r=robwu,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/ecc3f031dd6d
support internal command _execute_action r=robwu
https://hg.mozilla.org/integration/autoland/rev/503e92fb9813
support action context type for context menus r=robwu

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eeb832bfd3da
https://hg.mozilla.org/mozilla-central/rev/ecc3f031dd6d
https://hg.mozilla.org/mozilla-central/rev/503e92fb9813

Comment 6

[Rob Wu [:robwu]]

These aliases haven't been documented. I don't see any mention of it at:

• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands
• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/create
• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/update

The "command" key in the menus APIs should refer to the special command section of the commands API.
The commands API should document that _execute_browser_action is MV2-only, and replaced with _execute_action in MV3. Also worth mentioning that in Chromium browsers (Chrome/Edge/Opera/etc) that _execute_page_action is no longer supported because these browsers have dropped the page_action API in favor of action.

Comment 7

[rbloor]

These items are documented in the special shortcuts section of the command manifest key, which in turn is referenced from the Command API description. Do we need further changes?

Comment 8

[Rob Wu [:robwu]]

This has already been covered by https://github.com/mdn/content/pull/22018 .

Comment 9

[Rob Wu [:robwu]]

Richard, we missed an article here.
Could you add action to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/ContextType and its BCD?

The existing browser_action item should emphasize that it is in MV2 only, the new action item should emphasize that it's MV3 only.

Comment 10

[rbloor]

Changes made in (content) #24844 and (BCD) #19005