1706409 - Tab-crash allowing camera+microphone with MOZ_LOG=MediaManager:4

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STRs:

1. Go to https://jsfiddle.net/jib1/r60bzmrs/
2. Allow camera

Expected results:

• Video appears

Actual result:

• bp-0ea66bb6-d794-4f05-b8d0-a0f610210420

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: Tab crash on all camera/microphone/screen-share use on systems configured with WebRTC-specific developer-level logging (MOZ_LOG=MediaManager:4), caused by simple log-statement mistake.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1706409 - Fix MediaManager log statement to not crash when starting media. r?ng

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc8e07caa633
Fix MediaManager log statement to not crash when starting media. r=ng

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fc8e07caa633

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9217141 [details]
Bug 1706409 - Fix MediaManager log statement to not crash when starting media. r?ng

Beta/Release Uplift Approval Request

• User impact if declined: Cam/mic stops working and tab crashes instead, for users who have WebRTC-specific logging enabled on their system (MOZ_LOG=MediaManager:4)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://jsfiddle.net/jib1/59og5vhn/
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple mistake in LOG statement due to refactor.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217141 [details]
Bug 1706409 - Fix MediaManager log statement to not crash when starting media. r?ng

Low risk and a 89 regression, we are still early in the beta cycle, uplift approved for 89 Beta 3, thanks.

Comment 7

[Peter Magyari (Desktop QA)]

Hi Jan,

I'm trying to verify the fix but I'm not sure how to enable WebRTC-specific logging on my system (MOZ_LOG=MediaManager:4)
Could you help me out with some steps on how to do this ?

Thank you!

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The simplest is probably from a Terminal, e.g. on macOS:

★ ~ $ export MOZ_LOG=MediaManager:4
★ ~ $ /Applications/Firefox\ Nightly.app/Contents/MacOS/firefox

You might also be able to set MediaManager:4 from the about:networking#logging page

LMK if you're having trouble.

Comment 9

[Peter Magyari (Desktop QA)]

I was able to reproduce the issue on Beta 89.0b2 (20210420191345) and I've verified the fix on Nightly 90.0a1 (20210422093115)
I'll be back to verify it when it gets uplifted to 89 Beta 3.

Thanks for the extra steps Jan!

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/35035b086d49

Comment 11

[Peter Magyari (Desktop QA)]

I've also verified the fix on Beta 89.0b3 (20210422190146)