1706459 - Adjust find bar focusing style

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Emma Malysz]

When the string is not found, the input box will have a red highlight: https://searchfox.org/mozilla-central/rev/9b430bb1a11d7152cab2af4574f451ffb906b052/toolkit/themes/shared/findBar.inc.css#77-79

This #E22850 color looks very similar to the Linux system color, so it can be confusing for users and make it difficult to differentiate between highlights.

:ntim suggested we adjust the moz-accent-color in the find bar to color-mix(in srgb, -moz-accent-color 50%, transparent) to create a better distinction

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690334

Comment 2

[Emma Malysz]

We should also apply the rules from bug 1701910 to properly round the corners

Comment 3

[Emma Malysz]

Attachment: Bug 1706459, adjust moz-accent color and prevent antialising between the border and outline of findbar

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c20c2c44a2
adjust moz-accent color and prevent antialising between the border and outline of findbar r=harry

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/86c20c2c44a2

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emma Malysz]

Comment on attachment 9217567 [details]
Bug 1706459, adjust moz-accent color and prevent antialising between the border and outline of findbar

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes. Involves one color change for findbar focusing
• String changes made/needed: n/a

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217567 [details]
Bug 1706459, adjust moz-accent color and prevent antialising between the border and outline of findbar

Approved for 89 beta 5, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b8f980290202