Closed Bug 1706465 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28606 - Add JSON modules tests for charset, integrity, and MIME type parameters

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28606 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28606
Details from upstream follow.

b'Daniel Clark <daniec@microsoft.com>' wrote:

Add JSON modules tests for charset, integrity, and MIME type parameters

Add JSON modules tests for the following:

  • The \<script> element's integrity attribute is respected.
  • JSON modules are always decoded as UTF-8 regardless of Content-Type
    or the document's encoding. The existing coverage we had on this in
    utf8.tenative.html was renamed to charset.html, refactored, and
    expanded.
  • Adding parameters to the MIME type doesn't prevent it from being
    evaluated as a JSON MIME type.

Note, some of the existing MIME type tests for /+json still fail
because it seems the spec issue on these at
https://github.com/whatwg/mimesniff/issues/112 hasn't been fully
resolved. I'll follow up with that separately.

Bug: 1132413
Change-Id: I682de01bbb14b53214fcc16f427a4875f8cfed7f

Reviewed-on: https://chromium-review.googlesource.com/2841103
WPT-Export-Revision: 489846bc56033a08473e99a78d253a03d178fa77

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 6 subtests

Status Summary

Firefox

ERROR : 4
NOTRUN : 6

Chrome

OK : 4
PASS : 12
FAIL : 2

Safari

OK : 2
PASS : 1
FAIL : 7
TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/semantics/scripting-1/the-script-element/json-module/integrity.html: ERROR
/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative.html: ERROR linked bug:Bug 1692131

New Tests That Don't Pass

/html/semantics/scripting-1/the-script-element/json-module/charset-2.html: ERROR (Chrome: OK, Safari: TIMEOUT)
/html/semantics/scripting-1/the-script-element/json-module/charset.html: ERROR (Chrome: OK, Safari: ERROR)
/html/semantics/scripting-1/the-script-element/json-module/integrity.html: ERROR (Chrome: OK, Safari: OK)
/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative.html: ERROR (Chrome: OK, Safari: OK)
text/json: NOTRUN (Chrome: PASS, Safari: FAIL)
application/json: NOTRUN (Chrome: PASS, Safari: FAIL)
text/html+json: NOTRUN (Chrome: FAIL, Safari: FAIL)
image/svg+json: NOTRUN (Chrome: FAIL, Safari: FAIL)
text/json;boundary=something: NOTRUN (Chrome: PASS, Safari: FAIL)
text/json;foo=bar: NOTRUN (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4afecde09929 [wpt PR 28606] - Add JSON modules tests for charset, integrity, and MIME type parameters, a=testonly https://hg.mozilla.org/integration/autoland/rev/2cec9a478618 [wpt PR 28606] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.