1706478 - Onboarding container is very tall in initial slide

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Jody Heavener]

Attachment: fixed-height-slider.png

steps to reproduce/what did you do?

• Setup: Theme set to Default (and system set to Dark), and 'browser.aboutwelcome.design' set to 'proton'
• Visit about:welcome and start onboarding flow
• View the Import step, observe the space below the pagination dots
• View the Theme Selection step

expected behavior/ what did you think will happen?

• There is a reasonable amount of space at at the bottom of the container

actual behavior/ what actually happened?

• There is an excessive amount of space at the bottom of the container

additional notes

I think this is just fixed height since the second slide does take up the whole height of the container and it looks fine. This issue is just with the first slide. An argument could be made for a fixed height here to avoid the container jumping around. Notably this issue does not occur at mobile window sizes.

Comment 1

[Ed Lee :Mardak]

Design feedback was "Please ensure modal (white boxes) are the same size for import and theme selection screens"

Maybe the content should be spaced differently though?

Comment 2

[Ed Lee :Mardak]

Patch in bug 1698204 fixes this.

Comment 3

[Ed Lee :Mardak]

Other bug fixed by moving steps indicator to the bottom edge as well as pushing down buttons a bit too, so they're in the same positions on the latter screens.

https://hg.mozilla.org/mozilla-central/rev/88ca58d4c08e

Comment 4

[Romain Testard [:RT]]

Can this one be uplifted to Beta 89 please?

Comment 5

[Ed Lee :Mardak]

There's a win7 regression bug 1709805 as there's no steps indicator for the single center slide, so we'll need to fix that before uplifting this.

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following:

• The Logo and the "Import headline" are displayed in the top half of the Upgrading modal.
• The "Import from previous browser", the "Not now" button, and both indicators are displayed at the bottom of the Upgrading modal.

The verification was done using Firefox Nightly 90.0a1 (Build ID: 20210509213623) on Windows 10 x64, macOS 11.3.1, and Ubuntu Linux 20.04 x64.

Comment 7

[Ed Lee :Mardak]

Uplifted as part of bug 1698204 comment 17
https://hg.mozilla.org/releases/mozilla-beta/rev/e416e9bc17c9

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

This enhancement was part of the work done on [PI-1013] Proton: Onboarding which was signed off as GREEN. Considering this I am changing the status for Firefox 89 to Verified.