1706489 - Allow for calculating upgrade dialog funnel by first screen primary action

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

The first screen has 4 possible primary actions:

• primary
• default
• pin
• theme

We already have event telemetry from bug 1697222 when users click on a given button but don't know how many times a button is dynamically shown.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r?pdahiya,nanj

Reuse existing "show" event object to track which primary button was shown on the first screen.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac594597045
Allow for calculating upgrade dialog funnel by first screen primary action r=nanj

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_browserGlue_upgradeDialog

Backout link: https://hg.mozilla.org/integration/autoland/rev/7f33f31f0e384d3696cae657be3f40e5ebb03600

Push with failures

Failure log

INFO - TEST-PASS | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | parent must be in snapshot. Has [parent]. - true == true -
[task 2021-04-21T05:36:03.280Z] 05:36:03 INFO - Buffered messages finished
[task 2021-04-21T05:36:03.280Z] 05:36:03 INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | After filtering we must have the expected number of events. - 4 == 3 - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 177

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73ef5130bfff
Allow for calculating upgrade dialog funnel by first screen primary action r=nanj

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/73ef5130bfff

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9217227 [details]
Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r?pdahiya,nanj

Beta/Release Uplift Approval Request

• User impact if declined: Inability to determine click-through rates of upgrade dialog primary button
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. set browser.startup.homepage_override.mstone to 88

2. ensure browser.startup.upgradeDialog.version is empty
3. restart
4. see upgrade dialog and click the blue primary button
5. check about:telemetry#events-tab for upgrade_dialog#content#show#<button-displayed>

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adding one event telemetry without changing user visible behavior or designs
• String changes made/needed: none

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from comment 6 and I can confirm that the "upgrade_dialog#content#show#upgrade-dialog-new-primary-default-button" event is successfully displayed in the "about:telemetry#events-tab" page.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210422213157) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217227 [details]
Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r?pdahiya,nanj

Approved for 89 beta 5, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fbf7e3823eee

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from comment 6 and I can confirm that the "upgrade_dialog#content#show#upgrade-dialog-new-primary-default-button" event is successfully displayed in the "about:telemetry#events-tab" page.

Verified using the latest Firefox Beta (89.0b5 Build ID - 20210427185821) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.