1706520 - error: use of undeclared identifier 'GdkIsX11Display' in nsNativeThemeGTK.cpp and nsPrintDialogGTK.cpp

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Thomas Wisniewski [:twisniewski]]

I just rebased moz-central a couple of hours ago (April 20 2021), clobbered upon request, and my fresh build failed with errors indicating that GdkIsX11Display and GdkIsWaylandDisplay are not defined.

I was able to resolve the errors by adding #include "mozilla/WidgetUtilsGtk.h" to both nsNativeThemeGTK.cpp and nsPrintDialogGTK.cpp.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

I see. Do you build without Wayland support?

Comment 2

[Petr Sumbera]

I see the same on Solaris (no Wayland):

18:56.74 /builds/psumbera/mozilla-central-build/widget/gtk/nsNativeThemeGTK.cpp: In function ?void DrawThemeWithCairo(gfxContext*, mozilla::gfx::DrawTarget*, GtkWidgetState, WidgetNodeType, gint, GtkTextDirection, gint, bool, const Point&, const nsIntSize&, GdkRectangle&, nsITheme::Transparency)?:
18:56.74 /builds/psumbera/mozilla-central-build/widget/gtk/nsNativeThemeGTK.cpp:876:7: error: ?GdkIsX11Display? was not declared in this scope; did you mean ?GdkX11Display??18:56.74   876 |   if (GdkIsX11Display()) {
18:56.74       |       ^~~~~~~~~~~~~~~
18:56.74       |       GdkX11Display
18:56.79 /builds/psumbera/mozilla-central-build/widget/gtk/nsNativeThemeGTK.cpp: In member function ?virtual nsresult nsNativeThemeGTK::DrawWidgetBackground(gfxContext*, nsIFrame*, nsITheme::StyleAppearance, const nsRect&, const nsRect&, nsITheme::DrawOverflow)?:
..

The first bad revision is:
Destryoing build FS
The first bad revision is:
changeset: 576755:1f940b0cd2e1
user: stransky <[e-mail]>
date: Tue Apr 20 05:29:01 2021 -0700
description:
Bug 1706022 [Linux] Use GdkIsWaylandDisplay()/GdkIsX11Display() instead of gfxPlatformGtk::GetPlatform() variants, r=jhorak

    Differential Revision: https://phabricator.services.mozilla.com/D112525

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1706520 [Linux] Add missing WidgetUtilsGtk.h headers to widget/gtk, r?jhorak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/088249ce3aa2
[Linux] Add missing WidgetUtilsGtk.h headers to widget/gtk, r=emilio

Comment 5

[Thomas Wisniewski [:twisniewski]]

I see. Do you build without Wayland support?

Yes, I'm building for X11.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/088249ce3aa2