Closed
Bug 1706534
Opened 3 years ago
Closed 2 years ago
Links in prompts are full-length, use system accent color
Categories
(Firefox :: Theme, enhancement, P2)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: j.heavener, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [foxfooding] [internal] [proton-foxfooding] [proton-door-hangers] [priority:2b])
Attachments
(4 files)
steps to reproduce/what did you do?
- Open a prompt that has a link or CTA that is not a button (for example, a web page that requests persistent storage).
- Using your keyboard, focus on that link
expected behavior/ what did you think will happen?
- Link is visibly focused using a theme color, and is sized as an inline block
actual behavior/ what actually happened?
- Link spans full-width of prompt
- Focus color is system accent
Reporter | ||
Comment 1•3 years ago
|
||
Here's another example
Reporter | ||
Comment 2•3 years ago
|
||
Here's an example of the style I was expecting; it's inline block style, and has a white dotted border that matches with the theme (though I can also see the system accent color in there)
Updated•3 years ago
|
Whiteboard: [proton-onboarding] [foxfooding]
Updated•3 years ago
|
Whiteboard: [proton-onboarding] [foxfooding] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding]
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1340
Updated•3 years ago
|
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals]
Updated•3 years ago
|
Priority: -- → P2
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b]
Comment 3•3 years ago
|
||
Might need a css declaration around here? https://searchfox.org/mozilla-central/rev/6cbe34b441f7c7c29cd1e5f0e19c7000142f1423/toolkit/themes/shared/popupnotification.inc.css#251-253
Blocks: proton-door-hangers
Component: Foxfooding → Theme
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b] → [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b]
Updated•3 years ago
|
Whiteboard: [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b] → [foxfooding][internal] [proton-foxfooding][proton-door-hangers] [priority:2b]
Updated•3 years ago
|
Whiteboard: [foxfooding][internal] [proton-foxfooding][proton-door-hangers] [priority:2b] → [foxfooding] [internal] [proton-foxfooding] [proton-door-hangers] [priority:2b]
Assignee | ||
Comment 4•3 years ago
|
||
This isn't actually the system color, it's this one: https://searchfox.org/mozilla-central/rev/3151f97de27730793c2e298716df760999423f26/browser/themes/shared/browser.inc.css#129
Assignee: nobody → dao+bmo
Severity: -- → S4
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 2
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Iteration: 90.2 - May 3 - May 16 → 95.1 - Oct 4 - Oct 17
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3132e2d5dc45 Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry
Comment 7•2 years ago
|
||
Backed out for causing mochitest failures on browser_creditCard_doorhanger.js
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/233f66b65bed Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry
Comment 10•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•