Closed Bug 1706534 Opened 2 years ago Closed 1 year ago

Links in prompts are full-length, use system accent color

Categories

(Firefox :: Theme, enhancement, P2)

enhancement
Points:
2

Tracking

()

RESOLVED FIXED
95 Branch
Iteration:
95.1 - Oct 4 - Oct 17
Tracking Status
firefox95 --- fixed

People

(Reporter: j.heavener, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [foxfooding] [internal] [proton-foxfooding] [proton-door-hangers] [priority:2b])

Attachments

(4 files)

steps to reproduce/what did you do?

  • Open a prompt that has a link or CTA that is not a button (for example, a web page that requests persistent storage).
  • Using your keyboard, focus on that link

expected behavior/ what did you think will happen?

  • Link is visibly focused using a theme color, and is sized as an inline block

actual behavior/ what actually happened?

  • Link spans full-width of prompt
  • Focus color is system accent

Here's another example

Here's an example of the style I was expecting; it's inline block style, and has a white dotted border that matches with the theme (though I can also see the system accent color in there)

Whiteboard: [proton-onboarding] [foxfooding]
Whiteboard: [proton-onboarding] [foxfooding] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding]
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals]
Priority: -- → P2
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] → [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b]
Component: Foxfooding → Theme
Whiteboard: [proton-onboarding] [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b] → [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b]
Whiteboard: [foxfooding][internal] [proton-foxfooding][proton-modals] [priority:2b] → [foxfooding][internal] [proton-foxfooding][proton-door-hangers] [priority:2b]
Whiteboard: [foxfooding][internal] [proton-foxfooding][proton-door-hangers] [priority:2b] → [foxfooding] [internal] [proton-foxfooding] [proton-door-hangers] [priority:2b]
Assignee: nobody → dao+bmo
Severity: -- → S4
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 2
Depends on: 1624311
Iteration: 90.2 - May 3 - May 16 → 95.1 - Oct 4 - Oct 17
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3132e2d5dc45
Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry

Backed out for causing mochitest failures on browser_creditCard_doorhanger.js

Flags: needinfo?(dao+bmo)

Updated the patch.

Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/233f66b65bed
Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Regressions: 1754592
You need to log in before you can comment on or make changes to this bug.