Closed Bug 1706550 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28612 - [ImageDecoder] Remove decodeMetadata() in favor of tracks.ready.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28612 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28612
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

[ImageDecoder] Remove decodeMetadata() in favor of tracks.ready.

Since metadata is always queued automatically, decodeMetadata()
doesn't really do what it says. There's a better web idiom for
this a 'ready' property that's a one-time resolved promise.

Instead of calling decodeMetadata(), clients should just use
decode.tracks.ready.then(...)

Since the last round of breaking changes didn't cause any
issues without a deprecation period, drop decodeMetadata()
without a deprecation period as well.

Fixed: 1182435

Change-Id: I95317d6daaba9a98a7f33d594b50921800a6fbe3
Reviewed-on: https://chromium-review.googlesource.com/2842034
WPT-Export-Revision: e3fe6f6cf7ad9a4cf586819fbd336b510a495868

PR 28612 applied with additional changes from upstream: 9de16442c812a5dc2411a288bd141ed80b0aa251

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 30 subtests

Status Summary

Firefox

OK : 2
FAIL : 60

Chrome

PASS : 36
FAIL : 24
ERROR: 2

Safari

OK : 2
FAIL : 60

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/image-decoder.any.worker.html
Test JPEG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test PNG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test high bit depth HDR AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=false.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=true.: FAIL (Chrome: PASS, Safari: FAIL)
Test WEBP image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test GIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:2:2 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:4:4 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test WEBP image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid mime type rejects decode() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decodeMetadata() requests: FAIL (Chrome: FAIL, Safari: FAIL)
Test out of range index returns IndexSizeError: FAIL (Chrome: PASS, Safari: FAIL)
Test partial decoding without a frame results in an error: FAIL (Chrome: FAIL, Safari: FAIL)
Test decode, decodeMetadata after no track selected.: FAIL (Chrome: FAIL, Safari: FAIL)
Test track selection in multi track image.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream of gif: FAIL (Chrome: FAIL, Safari: FAIL)
Test that decode requests are serialized.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream aborts promises on track change: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/image-decoder.any.html
Test JPEG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test PNG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test high bit depth HDR AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=false.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=true.: FAIL (Chrome: PASS, Safari: FAIL)
Test WEBP image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test GIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:2:2 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test AVIF image YUV 4:4:4 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test WEBP image YUV 4:2:0 decoding.: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid mime type rejects decode() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decodeMetadata() requests: FAIL (Chrome: FAIL, Safari: FAIL)
Test out of range index returns IndexSizeError: FAIL (Chrome: PASS, Safari: FAIL)
Test partial decoding without a frame results in an error: FAIL (Chrome: FAIL, Safari: FAIL)
Test decode, decodeMetadata after no track selected.: FAIL (Chrome: FAIL, Safari: FAIL)
Test track selection in multi track image.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream of gif: FAIL (Chrome: FAIL, Safari: FAIL)
Test that decode requests are serialized.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream aborts promises on track change: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72f72cf98b92
[wpt PR 28612] - [ImageDecoder] Remove decodeMetadata() in favor of tracks.ready., a=testonly

https://hg.mozilla.org/mozilla-central/rev/72f72cf98b92

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.