1706591 - Bad contrast on site information menu in dark theme

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect, P2)

Description

[Outvi V]

Attachment: Bad contrast on "Site information" > "Clear cookies and site data..."

STR:

1. Set to dark theme on Firefox (Dark or Alpenglow)
2. VIsit "Site information" > "Clear cookies and site data..."

ER: Decent text color.
AR: As shown by the attachment.

It's probably related to the case when I use a dark KDE desktop theme, but I can also reproduce this when installing Firefox in a Docker container, where only X11 session is shared.

Comment 1

[:Gijs (he/him)]

Which versions of Firefox are you seeing this with? The screenshot suggests nightly, and your bug comment suggests you can also reproduce with release - or was that nightly, too?

Comment 2

[Outvi V]

(In reply to :Gijs (he/him) from comment #1)

Which versions of Firefox are you seeing this with? The screenshot suggests nightly, and your bug comment suggests you can also reproduce with release - or was that nightly, too?

It is firefox-trunk [1] so that's also nightly. This problem seems to be on every revision with the proton-door-hangers enabled.

1. https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa

Comment 3

[Daniel Bodea [:danibodea]]

I have managed to reproduce in Fedora 33 and Ubuntu 20 with Nightly v90.0a1 and Beta v89.0b3.

When opening the Site Information Panel and hovering over the "Clear cookies and site data" the font color of the text changes to dark-
gray incorrectly.

Comment 4

[Ciprian Georgiu, Desktop QA]

This is no longer an issue on Ubuntu 18.04 x64 using Beta 89.0b8 and latest Nightly 90.0a1. Tested with Dark or Alpenglow themes.

Comment 5

[Kestrel]

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27780a561fa02a7df9f3068f3f1d6dadde083c87&tochange=02c956ff0d2f2c3584939f6d1879dad39795738d

Fixed by Bug 1708690.