1706775 - Ensure that various menu tests under toolkit/content/tests/chrome are run on non-native menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

The following tests are meant to exercise our non-native menu code:

toolkit/content/tests/chrome/test_contextmenu_list.xhtml
toolkit/content/tests/chrome/test_largemenu.html
toolkit/content/tests/chrome/test_popup_attribute.xhtml
toolkit/content/tests/chrome/test_popup_button.xhtml

When native context menus are enabled, we do not use our non-native menu code for context menus any more. However, we still use the code for other popups which are not context menus, for example for toolbar button dropdowns. As long as this is the case, we should keep our test coverage of non-native menu code on macOS.
We can achieve this by setting the pref widget.macos.native-context-menus to false in these tests.

There are some aspects of these tests which are worth testing on native context menus, too. I'm planning to make a list of those aspects and put it into bug 1700727, and then add separate tests for them as a follow-up. That way, our "menu implementation" tests will be neatly split into separate files: Some files which only test the non-native implementation, and some files which only test the native implementation.
And we also have a whole host of tests which are implementation-agnostic - any test which calls activateItem, for example.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1706775 - Ensure that various menu tests under toolkit/content/tests/chrome are run on non-native menus. r=harry

These tests are meant to exercise our non-native menu code.
Some aspects of these tests are worth testing with native menus, too -
we will have separate native menu test files for those.

Once we do not use non-native menus anywhere on macOS anymore, we can
disable these tests on macOS. However, for now, we still use non-native
menus for 'anchored popups', e.g. toolbar button dropdowns.
In order to retain test coverage for our non-native menu code, we make
sure that these tests are run with native context menus turned off.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c376b409702c
Ensure that various menu tests under toolkit/content/tests/chrome are run on non-native menus. r=harry

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c376b409702c

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a48489c54949