1706783 - clean up processor started_datetime/starteddatetime and completed_datetime/completeddatetime

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I was looking at this line:

start_time = self.logger.info("starting transform for crash: %s", crash_id)

https://github.com/mozilla-services/socorro/blob/d65ccc4cb20b7fc982808934f79a13d1a95d5e7f/socorro/processor/processor_pipeline.py

and that made no sense to me. That variable gets assigned to processor_meta_data and doesn't get used anywhere. Which is good because the value is always None. Looking at the reconstitute code here:

https://github.com/mozilla-services/socorro/blob/d65ccc4cb20b7fc982808934f79a13d1a95d5e7f/socorro/external/es/crashstorage.py#L46

Looks like there have been several variations of both of these fields.

They don't get displayed anywhere in the webapp. I think they're supposed to mark the start and end datetime for the most recent processing run for the crash report.

Bug #1626811 covers improving the processor notes so they're more of a log of what happened and are more helpful. I think the start/completed times should definitely go in there. I'm on the fence about whether to store them in the processed crash as well.

This bug covers cleaning all this up.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I was just looking at this. Might as well grab it now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5902: bug 1706783: remove completeddatetime and startedDateTime

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5902: "bug 1706783: remove completeddatetime and startedDateTime" in f9714c0.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod in bug #1744108. Marking as FIXED.