[macOS] The toolbar is cut off while in full screen and using shifting toolbar option
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | + | verified |
firefox90 | --- | verified |
People
(Reporter: atrif, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [mac:fullscreen][proton] [priority:2a] [proton-uplift] )
Attachments
(2 files)
1.00 MB,
video/quicktime
|
Details | |
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 90.0a1(20210421212740)
Affected platforms
- macOS 11.2.3
- macOS 10.15
Steps to reproduce
- Open Firefox and enter fullscreen.
- Move the mouse to the top of the browser.
Expected result
- The toolbar and tabs bar is displayed as expected.
Actual result
- The toolbar and tabs are cut off.
Regression range
- I will search for one ASAP.
Notes
- Attached a screen recording.
- This is reproducible with native fullscreen enabled and disabled as well.
- S2 because it affects the functionality of the newly implemented shifting toolbar feature.
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
Attaching regression range:
Last good revision: 416cce562ac233753218454e22d1ff0e1e061815
First bad revision: a119c6860f429847367a87405cf791da5110ef19
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=416cce562ac233753218454e22d1ff0e1e061815&tochange=a119c6860f429847367a87405cf791da5110ef19
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
If this was regressed by 1704865, its a toolbars or theme issue. I'll move to toolbars for now.
That patch removed the animatable box for the bookmark button, and some other supporting CSS that should have been no longer necessary. But it seems to have changed the way we calculate toolbar height for the full screen behavior.
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
I think it was the removal of position: relative
on #navigator-toolbox
.
I would argue that this is a P1 as there's obvious visual breakage in a surface that users encounter often. It will affect 89 once bug 1704865 is uplifted. But I'll leave prioritization up to the Proton triagers.
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
[Tracking Requested - why for this release]:
Major UI regression in macOS fullscreen. Simple patch with easy uplift.
Assignee | ||
Comment 9•3 years ago
|
||
I'll request uplift tomorrow after I've verified the fix in Nightly.
Comment 10•3 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d689f6b43a56 Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao
Comment 11•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Assignee | ||
Comment 12•3 years ago
|
||
Comment on attachment 9218838 [details]
Bug 1706901 - Allow the toolbar to shift with position: relative. r?mstange!
Beta/Release Uplift Approval Request
- User impact if declined: Major visual regression in macOS fullscreen. Some parts of the toolbar will be unusable when the mouse is at the top of the screen.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Two-line style fix. Simply reverts something removed accidentally in bug 1704865.
- String changes made/needed:
Updated•3 years ago
|
Comment 13•3 years ago
|
||
Comment on attachment 9218838 [details]
Bug 1706901 - Allow the toolbar to shift with position: relative. r?mstange!
Approved for 89 beta 6, thanks.
Comment 14•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Reporter | ||
Comment 15•3 years ago
|
||
Verified fixed with Firefox 90.0a1 (20210504214950) and 89.0b8 on macOS 11.2.3 and 10.15.
Description
•