Closed Bug 1706981 Opened 3 years ago Closed 3 years ago

Bookmarks Menu Toolbar button submenu items have incorrectly placed chevron on Windows

Categories

(Firefox :: Menus, defect, P2)

Product:
Firefox
Component:
Menus
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed
firefox95 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers] [priority:2b])

Attachments

(4 files)

image.png
15.27 KB, image/png
Details
Screenshot_1.png
11.47 KB, image/png
Details
image.png
40.45 KB, image/png
Details
Bug 1706981 - Fix placement of chevron for Bookmarks Menu button menupopups on Windows 10. r?emalysz!
48 bytes, text/x-phabricator-request
Details | Review
Attached image image.png —

See screenshot. They're too far left, and should match the positioning in panels like the AppMenu panel.

Priority: -- → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2b]
Attached image Screenshot_1.png —
Flags: needinfo?(mconley)

Hi Mike! Do you still see this issue on your end? It looks fine on my machine with Win 10, running latest Nightly 90.0a1. Please see the above image.

Attached image image.png —

I do, yes - the subview arrows are still too far from the rightmost edge. See the attached image for reference.

Flags: needinfo?(mconley)
Severity: -- → S3
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #9222504 - Attachment description: Bug 1706981 - Fix placement of chevron for Bookmarks Toolbar menupopups on Windows 10. r?emalysz! → Bug 1706981 - Fix placement of chevron for Bookmarks Menu button menupopups on Windows 10. r?emalysz!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a9a66211b48
Fix placement of chevron for Bookmarks Menu button menupopups on Windows 10. r=emalysz

https://hg.mozilla.org/mozilla-central/rev/4a9a66211b48

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Flags: qe-verify+

Hi Mike, I checked on Win10 NB_90.0a1 and the Bookmark menu options look more distanced than they do on Latest RC_95.0b1, so I am marking the bug as verified, but if you consider that they still do not look Ok, please re-open the issue.

Thank you.

Status: RESOLVED → VERIFIED
Flags: needinfo?(mconley)
status-firefox95: --- → verified
Flags: qe-verify+

Thanks Monica for verifying the bug - I think we're good here.

Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: