1706998 - Crash in [@ mozilla::dom::quota::QuotaManager::MaybeRecordShutdownStep]

Status: RESOLVED FIXED

(Core :: Storage: StorageManager, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

95% of crashes on Windows 10, the other ones Windows except 4 macOS crashes

Crash report: https://crash-stats.mozilla.org/report/index/44db734f-9de4-4b7a-9971-d0f420210422

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::quota::QuotaManager::MaybeRecordShutdownStep dom/quota/ActorsParent.cpp:3655
1 xul.dll static mozilla::dom::cache::Manager::Factory::Remove dom/cache/Manager.cpp:274
2 xul.dll mozilla::dom::cache::Context::~Context dom/cache/Context.cpp:920
3 xul.dll mozilla::SafeRefPtr<mozilla::dom::cache::Context>::assign_assuming_AddRef dom/indexedDB/SafeRefPtr.h:172
4 xul.dll mozilla::dom::cache::Context::ActionRunnable::Clear dom/cache/Context.cpp:572
5 xul.dll mozilla::dom::cache::Context::ActionRunnable::Run dom/cache/Context.cpp:686
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1145
7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:328
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:310

Comment 1

[Jens Stutte [:jstutte]]

It seems that the IPDL Background thread is processing events even after that the RecvShutdownQuotaManager has been processed, which nulled out the gInstance.

Before using quota::QuotaManager::GetRef() we should probably check IsShuttingDown() (or have static wrapper functions that do this for us).

Comment 2

[Jens Stutte [:jstutte]]

Attachment: Bug 1706998: Replace QuotaManager::GetRef().MaybeRecordShutdownStep by static QuotaManager::(Safe)MaybeRecordQuotaClientShutdownStep; r=#dom-storage

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8a45415dc5b
Replace QuotaManager::GetRef().MaybeRecordShutdownStep by static QuotaManager::(Safe)MaybeRecordQuotaClientShutdownStep; r=dom-storage-reviewers,janv

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c8a45415dc5b