1707005 - Almost no contrast in Alpenglow findbar input

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Harry Twyford]

Attachment: alpenglow-light.png

The unfocused findbar textbox has almost no contrast in both Alpenglow Dark and Alpenglow Light. Screenshots attached.

Comment 1

[Harry Twyford]

Attachment: alpenglow-dark.png

Comment 2

[Tyler Duzan]

Did this regress due to Proton? My understanding is that Alpenglow improvements weren't in scope for MR1

Comment 3

[Harry Twyford]

Attachment: 88-alpenglow-light

Yes, it's a Proton regression. Here's the findbar on Release 88 Alpenglow Light.

Comment 4

[Harry Twyford]

Attachment: 88-alpenglow-dark

Comment 5

[Daniel Bodea [:danibodea]]

I feel like mentioning that if we are to ignore the background color of the input box versus the background color of the Findbar (color contrast issue), a separator line is observed around the Input box and next/previous buttons in Dark Theme, but not in the Light or Alpenglow Themes.

Comment 6

[Itiel]

Attachment: Bug 1707005 - Improve themes support for the findbar r?#desktop-theme-reviewers,sfoster

Comment 7

[Itiel]

Hi guys,

Please let me know what you think about this approach.
In the WIP patch I've made the find bar to look and feel the exact same as the toolbar, so this fixes the issue at hand almost for all themes (there are themes in which the urlbar has the same issue, so this is kinda the theme author's fault and thus not a part of this patch).
As for themes with lwtheme-image, I've made it so that the findbar will be sort of an "extension" of the toolbar/toolbox above, so only the bottom part of the image would be shown in there. See attached screenshots with several themes I've tested this with. Light and Dark themes are unaffected for the most part (hover states were changed to be like the toolbar's).
I've also made some general improvements to match the hover states, text-shadow, colors etc of the toolbox.
From my testings this works well on Light, Dark, themes, pure HCM and HCM with themes.

The patch was made specifically for Windows and so may not work well (at this time) on other platforms. I'd like to get your opinions on this before I proceed to made the needed adjustments and clean up the patch.

Thanks!

Comment 8

[Itiel]

Attachment: Patch with Light theme

Comment 9

[Itiel]

Attachment: Patch with Dark theme

Comment 10

[Itiel]

Attachment: Patch with Alpenglow light

Comment 11

[Itiel]

Attachment: Patch with Alpenglow dark

Comment 12

[Itiel]

Attachment: Patch with African Heat theme

Comment 13

[Itiel]

Attachment: Patch with "Beach chairs - Jen" theme

Comment 14

[Itiel]

Attachment: Patch with "colorful crazy cats by candelora" theme

Comment 15

[Itiel]

Attachment: Patch with "Fairytale Of Nature" theme

Comment 16

[Itiel]

Attachment: Patch with "Retro Circles and Rectangles" theme

Comment 17

[Itiel]

Attachment: Patch with pure HCM white enabled

Comment 18

[Itiel]

Attachment: Patch with pure HCM black enabled

Comment 19

[Harry Twyford]

I think that looks quite good! I'm curious what others think. If we can get a consensus among engineers that this is generally a good change, we can run it by UX.

Comment 20

[Emma Malysz]

Agreed, I think this looks better. Just a note we landed Bug 1724194 this week, so should apply the same rules to findbar-close-container as we do the findbar.

Comment 21

[Jared Wein [:jaws] (please needinfo? me)]

I applied the patch, looks good to me.

Comment 22

[Andrew Crago]

Reviewed by UX. Looks good.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8df08f0fe624
Improve themes support for the findbar r=desktop-theme-reviewers,sfoster

Comment 24

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_ext_themes_findbar.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b3f0d0e685a5ca41098933c3912659726c28dcc6
Log link: https://treeherder.mozilla.org/logviewer?job_id=412225508&repo=autoland&lineNumber=7882

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e3de5ce02e
Improve themes support for the findbar r=desktop-theme-reviewers,sfoster

Comment 26

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a8e3de5ce02e