Closed Bug 1707038 Opened 3 years ago Closed 3 years ago

Update validation of `utm_campaign` in RTAMO onboarding

Categories

(Firefox :: Messaging System, enhancement)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Flags:
Tracking Status
firefox90 --- verified

People

(Reporter: jorgev, Assigned: mixedpuppy)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1707038 remove strict utm_campaign validation for rtamo
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta-
Details | Review
Bug 1707038 update manual rtamo test with recommended addon and correct content format
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta-
Details | Review

Currently, RTAMO URLs have these params:

https://www.mozilla.org/firefox/new/?utm_source=addons.mozilla.org&utm_medium=referral&utm_campaign=non-fx-button&utm_content=rta%3AamlkMS1Nbm54Y3hpc0JQblNYUUBqZXRwYWNr

The last param (utm_content) identifies this as a RTAMO URL and the add-on that will be shown in the first run UX instead of the regular onboarding flow. The other 3 params (utm_source, utm_medium, utm_campaign) have fixed values and are also validated on the client side. If they don't match, the RTAMO UX isn't shown.

In order to experiment with the Download Firefox feature on AMO and have better attribution tracking, we want to make the utm_campaign value variable, so validating it wouldn't be as straightforward. Given that this param validation appears to just be a sanity check, perhaps it would be sufficient to stop checking utm_campaign and just rely on the other two values.

Seems like from bug 1530816, there's a "rta:" prefix that has special meaning that we could also use?

source == "addons.mozilla.org" &&
content?.startsWith("rta%3A")

The current code checks for source and campaign:
https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#403-408

See Also: → 1530816

Filed an equivalent issue for validation on the mozilla.org side: https://github.com/mozilla/bedrock/issues/10173

Assignee: nobody → mixedpuppy
Status: NEW → ASSIGNED

To speak to the urgency of this patch and the uplift request, there are some experiments we're running on AMO very soon (possibly starting next week) that will impact RTAMO if this isn't fixed. I'm okay with RTAMO not working temporarily for these experiments, but it's of course ideal if we minimize the impact. I asked Shane for an uplift request with the assumption that this would be a low risk patch.

A separate beta patch probably won't be necessary as the nearby attribution change in 90 is likely uplifted: bug 1703327 comment 8

Depends on: 1703327
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16a995d1204f
remove strict utm_campaign validation for rtamo r=Mardak
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54553dd780a6
remove strict utm_campaign validation for rtamo r=Mardak

https://hg.mozilla.org/mozilla-central/rev/54553dd780a6

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14ead18ad78b
update manual rtamo test with recommended addon and correct content format r=Mardak
Flags: needinfo?(mixedpuppy)
Attachment #9218984 - Attachment is obsolete: true

Comment on attachment 9218975 [details]
Bug 1707038 remove strict utm_campaign validation for rtamo

Beta/Release Uplift Approval Request

  • User impact if declined: Some new Firefox users from AMO don't continue to add-on installation (i.e., the RTAMO new user flow) when part of an experiment with custom "campaign" values potentially starting this week (see comment 5)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. enable browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
  1. open about:newtab -> click wrench devtools -> select "Targeting"
  2. set/force attributions (at bottom of page, details below)
  3. open about:welcome and see RTAMO (privacy badger as in comment 0)

Test attributions:
source: addons.mozilla.org
campaign: test-campaign
content: rta:amlkMS1Nbm54Y3hpc0JQblNYUUBqZXRwYWNr

(Before campaign was required to be "non-fx-button")

  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Removing some unnecessarily strict checks and updating internal devtools to assist dev/QA
  • String changes made/needed: none
Attachment #9218975 - Flags: approval-mozilla-beta?
Attachment #9219377 - Flags: approval-mozilla-beta?

This uplift could be approved, but it should wait to land for a few days. An alternative is being tested in the interim.

I have verified that "Privacy Badger" RTAMO is correctly displayed on the "about:welcome" page by following the steps provided in comment 14 using Firefox Nightly 90.0a1 (Build ID: 20210509213623) on Windows 10 x64, Windows 8.1 x64, and Windows 7 x64.

Status: RESOLVED → VERIFIED
status-firefox90: fixed → verified

(In reply to Shane Caraveo (:mixedpuppy) from comment #15)

This uplift could be approved, but it should wait to land for a few days. An alternative is being tested in the interim.

Shane, do you have an update on this? thanks

Flags: needinfo?(mixedpuppy)

I had a discussion with Jorge about this yesterday and it looks like the data we have for the current experiment is sufficient and therefore we do not need to uplift this.

Comment on attachment 9218975 [details]
Bug 1707038 remove strict utm_campaign validation for rtamo

Thanks

Attachment #9218975 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9219377 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
See Also: → 1712062
Iteration: --- → 90.1 - Apr 19 - May 2
Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: