Closed Bug 1707041 Opened 3 years ago Closed 2 years ago

Perma mozilla-release Android toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0

Categories

(Firefox :: Normandy Client, defect, P5)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1760098
Tracking Status
firefox-esr91 --- unaffected
firefox95 --- wontfix
firefox96 --- disabled
firefox97 --- disabled

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=337448915&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QqLJaRrBRySWLWJo7t2lPA/runs/0/artifacts/public/logs/live_backing.log


[task 2021-04-22T13:47:56.228Z] 13:47:56     INFO -  TEST-START | toolkit/components/utils/test/unit/test_ClientEnvironment.js
[task 2021-04-22T13:47:56.261Z] 13:47:56     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test/org.mozilla.geckoview.test.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/36b793d6-36d0-4392-b5d3-ce62e8eb190e/mozinfo.json";' --es arg9 -e --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-androidTest.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg26 '_execute_test(); quit(0);' --es arg25 -e --es arg24 'const _TEST_NAME = "toolkit/components/utils/test/unit/test_ClientEnvironment.js";' --es arg23 -e --es arg22 'const _TEST_FILE = ["test_ClientEnvironment.js"];' --es arg21 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/toolkit/components/utils/test/unit";' --ez use_multiprocess True --es env20 TMPDIR=/data/local/tmp/test_root/xpc/p/36b793d6-36d0-4392-b5d3-ce62e8eb190e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg16 'const _HEAD_FILES = [];' --es arg17 -e --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es env9 MOZHTTP2_PORT=44051 --es env8 GRE_HOME=/data/local/tmp/test_root/xpcb --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-123b3c8e-c566-403f-94b5-ef28d22d5056.log --es env3 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/36b793d6-36d0-4392-b5d3-ce62e8eb190e --es env2 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_DISABLE_SOCKET_PROCESS_SANDBOX=1 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env6 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/36477620-c7a3-4017-aacb-1af7fc6b99f8 --es env5 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env4 MOZ_WEBRENDER=0 --es env19 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 HOME=/data/local/tmp/test_root/xpc/p --es env17 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env16 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env15 MOZ_CRASHREPORTER_NO_REPORT=1 --es env14 MOZNODE_EXEC_PORT=40449 --es env13 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/36b793d6-36d0-4392-b5d3-ce62e8eb190e --es env12 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env11 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env10 MOZ_DISABLE_SOCKET_PROCESS=1
[task 2021-04-22T13:47:56.599Z] 13:47:56     INFO -  remotexpcshelltests.py | Launched Test App PID=13532
[task 2021-04-22T13:47:57.039Z] 13:47:57     INFO -  remotexpcshelltests.py | Application ran for: 0:00:00.810169
[task 2021-04-22T13:47:57.154Z] 13:47:57  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  TEST-INFO took 926ms
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  >>>>>>>
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-04-22T13:47:57.154Z] 13:47:57     INFO -  running event loop
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test pending (2)
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - OS data should be available in the context - true == true
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - At most one OS should match - true == true
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test finished (2)
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test pending (2)
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - Test environment does not have attribution data - "NS_ERROR_FILE_NOT_FOUND" == "NS_ERROR_FILE_NOT_FOUND"
[task 2021-04-22T13:47:57.155Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 2 pending (2)
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  (xpcshell/head.js) | test finished (2)
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting testLiveTelemetry
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  (xpcshell/head.js) | test testLiveTelemetry pending (2)
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  (xpcshell/head.js) | test run_next_test 2 finished (2)
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  Unexpected exception TypeError: ClientEnvironmentBase.liveTelemetry.main is null at test_ClientEnvironment.js:96
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  testLiveTelemetry@test_ClientEnvironment.js:96:1
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:241:6
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:598:5
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  @-e:1:1
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  exiting test
[task 2021-04-22T13:47:57.156Z] 13:47:57     INFO -  <<<<<<<```
Component: General → Telemetry
Summary: Intermittent toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0 → Intermittent mozilla-release Android toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0
Summary: Intermittent mozilla-release Android toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0 → Perma mozilla-release Android toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0

Hi Elise, this is currently perma-failing, can you please take a look?
TH link: https://treeherder.mozilla.org/jobs?repo=mozilla-release&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=fbfba27ecdf62e286a6ed285bb78250c02d3d4a1&selectedTaskRun=PaHcohZrSiG2-gQrn62nNw.0&searchStr=android-em-7-0-x86_64-shippable-lite-qr%2Copt%2CXpcshell%2Ctests%2Ctest-android-em-7.0-x86_64-shippable-lite-qr%2Fopt-geckoview-xpcshell-e10s%2CX1&tochange=bc7bb264b4442d05f790b4d7cb0a4726a9288b27

Failure log: https://treeherder.mozilla.org/logviewer?job_id=350800084&repo=mozilla-release&lineNumber=8755

[task 2021-09-07T15:38:32.342Z] 15:38:32     INFO -  TEST-START | toolkit/xre/test/test_launch_without_hang.js
[task 2021-09-07T15:38:32.342Z] 15:38:32     INFO -  TEST-SKIP | toolkit/xre/test/test_launch_without_hang.js | took 0ms
[task 2021-09-07T15:38:32.342Z] 15:38:32     INFO -  Retrying tests that failed when run in parallel.
[task 2021-09-07T15:38:32.979Z] 15:38:32     INFO -  TEST-START | toolkit/components/utils/test/unit/test_ClientEnvironment.js
[task 2021-09-07T15:38:33.012Z] 15:38:33     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test/org.mozilla.geckoview.test.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env6 MOZ_DISABLE_SOCKET_PROCESS=1 --es env7 MOZ_WEBRENDER=1 --es env8 MOZ_ACCELERATED=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/3e2b21e3-f55e-4bba-a3ab-b1093112d523 --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/f1f948c8-1b2e-4e8b-83a6-e2b79cc48a76 --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_ANDROID_CPU_ABI=x86_64 --es env17 MOZHTTP2_PORT=42959 --es env18 MOZNODE_EXEC_PORT=41907 --es env19 TMPDIR=/data/local/tmp/test_root/xpc/p/3e2b21e3-f55e-4bba-a3ab-b1093112d523 --es env20 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/3e2b21e3-f55e-4bba-a3ab-b1093112d523 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-androidTest.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/3e2b21e3-f55e-4bba-a3ab-b1093112d523/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = [];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/toolkit/components/utils/test/unit";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_ClientEnvironment.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "toolkit/components/utils/test/unit/test_ClientEnvironment.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-a56cbd80-60f2-46d0-9cbe-e93e59e1d237.log
[task 2021-09-07T15:38:33.288Z] 15:38:33     INFO -  remotexpcshelltests.py | Launched Test App PID=4064
[task 2021-09-07T15:38:33.708Z] 15:38:33     INFO -  remotexpcshelltests.py | Application ran for: 0:00:00.728724
[task 2021-09-07T15:38:33.813Z] 15:38:33  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/utils/test/unit/test_ClientEnvironment.js | xpcshell return code: 0
[task 2021-09-07T15:38:33.813Z] 15:38:33     INFO -  TEST-INFO took 833ms
[task 2021-09-07T15:38:33.813Z] 15:38:33     INFO -  >>>>>>>
[task 2021-09-07T15:38:33.813Z] 15:38:33     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-09-07T15:38:33.814Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-09-07T15:38:33.814Z] 15:38:33     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-09-07T15:38:33.814Z] 15:38:33     INFO -  running event loop
[task 2021-09-07T15:38:33.814Z] 15:38:33     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting
[task 2021-09-07T15:38:33.814Z] 15:38:33     INFO -  (xpcshell/head.js) | test pending (2)
[task 2021-09-07T15:38:33.815Z] 15:38:33     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - OS data should be available in the context - true == true
[task 2021-09-07T15:38:33.815Z] 15:38:33     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - At most one OS should match - true == true
[task 2021-09-07T15:38:33.815Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  (xpcshell/head.js) | test finished (2)
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  (xpcshell/head.js) | test pending (2)
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  TEST-PASS | toolkit/components/utils/test/unit/test_ClientEnvironment.js |  - Test environment does not have attribution data - "NS_ERROR_FILE_NOT_FOUND" == "NS_ERROR_FILE_NOT_FOUND"
[task 2021-09-07T15:38:33.816Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 2 pending (2)
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  (xpcshell/head.js) | test finished (2)
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  toolkit/components/utils/test/unit/test_ClientEnvironment.js | Starting testLiveTelemetry
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  (xpcshell/head.js) | test testLiveTelemetry pending (2)
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  (xpcshell/head.js) | test run_next_test 2 finished (2)
[task 2021-09-07T15:38:33.817Z] 15:38:33     INFO -  Unexpected exception TypeError: ClientEnvironmentBase.liveTelemetry.main is null at test_ClientEnvironment.js:96
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  testLiveTelemetry@test_ClientEnvironment.js:96:1
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:240:6
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:597:5
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  @-e:1:1
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  exiting test
[task 2021-09-07T15:38:33.818Z] 15:38:33     INFO -  <<<<<<<
[task 2021-09-07T15:38:33.931Z] 15:38:33     INFO -  Cleaning up profile for /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/utils/test/unit/test_ClientEnvironment.js folder: /data/local/tmp/test_root/xpc/p/3e2b21e3-f55e-4bba-a3ab-b1093112d523
[task 2021-09-07T15:38:34.247Z] 15:38:34     INFO -  INFO | Result summary:
[task 2021-09-07T15:38:34.247Z] 15:38:34     INFO -  INFO | Passed: 669
[task 2021-09-07T15:38:34.248Z] 15:38:34  WARNING -  INFO | Failed: 1
[task 2021-09-07T15:38:34.248Z] 15:38:34  WARNING -  One or more unittests failed.
[task 2021-09-07T15:38:34.248Z] 15:38:34     INFO -  INFO | Todo: 8
[task 2021-09-07T15:38:34.248Z] 15:38:34     INFO -  INFO | Retried: 1
[task 2021-09-07T15:38:34.249Z] 15:38:34     INFO -  SUITE-END | took 462s
[task 2021-09-07T15:38:34.250Z] 15:38:34     INFO -  Node moz-http2 server shutting down ...
[task 2021-09-07T15:38:34.305Z] 15:38:34    ERROR - Return code: 1
[task 2021-09-07T15:38:34.305Z] 15:38:34     INFO - TinderboxPrint: xpcshell<br/>669/<em class="testfail">1</em>/8
[task 2021-09-07T15:38:34.305Z] 15:38:34     INFO - ##### xpcshell log ends
[task 2021-09-07T15:38:34.306Z] 15:38:34  WARNING - # TBPL WARNING #
[task 2021-09-07T15:38:34.306Z] 15:38:34  WARNING - setting return code to 1
Flags: needinfo?(erichards)

This looks to be Glean/Telemetry code. See if Michael Droettboom knows who should own this or redirect.

Flags: needinfo?(erichards) → needinfo?(mdroettboom)

This looks like an issue with the legacy telemetry system which is written / maintained by the Fenix / Android team, not the Glean SDK team.

Flags: needinfo?(mdroettboom)

(In reply to Michael Droettboom [:mdroettboom] from comment #21)

This looks like an issue with the legacy telemetry system which is written / maintained by the Fenix / Android team, not the Glean SDK team.

I don't believe this is accurate, we (GeckoView / Android) don't maintain the telemetry system, and likewise not the Fenix team (who don't even use mozilla-central). Michael can you figure this out with Emily Toop (GV manager)?

Flags: needinfo?(erichards) → needinfo?(mdroettboom)

Sorry -- too many telemetry systems ;) chutten: I think maybe you have better context than I do to figure out how to triage this.

Flags: needinfo?(mdroettboom) → needinfo?(chutten)

test_ClientEnvironment.jsm tests ClientEnvironment.sjm which is part of Normandy (see bug 1472781) (( it reflects part of the Telemetry Environment in a way that Normandy can use. ))

It might be perma-failing due to bug 1722082 which :aryx already See Also'd. :Gijs, does this sound like something that may be related?

Also, :mythmon, does Normandy Client need test coverage on Android? Maybe we skip-if this test?

Component: Telemetry → Normandy Client
Flags: needinfo?(mcooper)
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(chutten)
Product: Toolkit → Firefox

As my bmo name indicates, I'm out until Monday the 20th, and so can't look much right now but:

(In reply to Chris H-C :chutten from comment #24)

test_ClientEnvironment.jsm tests ClientEnvironment.sjm which is part of Normandy (see bug 1472781) (( it reflects part of the Telemetry Environment in a way that Normandy can use. ))

It might be perma-failing due to bug 1722082 which :aryx already See Also'd. :Gijs, does this sound like something that may be related?

Not directly in the sense of the crashes that would occur from bug 1721627; the test isn't crashing, just failing:

[task 2021-09-07T15:38:33.817Z] 15:38:33 INFO - Unexpected exception TypeError: ClientEnvironmentBase.liveTelemetry.main is null at test_ClientEnvironment.js:96

I don't know enough about telemetry to know why that property would be null.

Is the same test passing on trunk/beta, or is it disabled, or...?

Flags: needinfo?(gijskruitbosch+bugs)

Also, :mythmon, does Normandy Client need test coverage on Android? Maybe we skip-if this test?

Normandy doesn't need coverage on Android, however ClientEnvironment is used by more than Normandy these days. It's also used by at least Remote Settings and Nimbus. I'm not sure if they use it on Android though.

Mat, Andrei, can you comment on if we need ClientEnvironment.jsm on Android for Remote Settings (Mat) or Nimbus (Andrei)?

Flags: needinfo?(mcooper)
Flags: needinfo?(mathieu)
Flags: needinfo?(andrei.br92)

In theory yes we need it. We want to offer the target filters feature everywhere RS is supported.
However, so far no collection has leveraged it, so if we have to deprecate it, we could.

Flags: needinfo?(mathieu)

Nimbus desktop code doesn't support Android so I don't have anything against skipping.

Flags: needinfo?(andrei.br92)

(In reply to Mathieu Leplatre [:leplatrem] from comment #27)

In theory yes we need it. We want to offer the target filters feature everywhere RS is supported.
However, so far no collection has leveraged it, so if we have to deprecate it, we could.

Sounds like we should "just" make ClientEnvironment.jsm not break on Android instead?

(In reply to :Gijs (he/him) from comment #31)

Sounds like we should "just" make ClientEnvironment.jsm not break on Android instead?

It's not great to leave tests permafailing on release for multiple cycles. Can you please respond to help move this bug forward?

Flags: needinfo?(mathieu)

I can see here that a similar code path is tested, and the test does not seem to be disabled on Android.

Same for test_amo_stats_telemetry.js.

I don't really know what to do with that :(
At this point, I could offer to disable the test and cannot invest much time into this.

Flags: needinfo?(mathieu)
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f1034e27934
Skip test_ClientEnvironment.js on Android for Beta/Release builds. r=leplatrem
Assignee: ryanvm → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: