Closed
Bug 1707074
Opened 3 years ago
Closed 3 years ago
Wrap debug logging for related realms feature in a pref check for said feature
Categories
(Toolkit :: Password Manager, task, P3)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: tgiles, Assigned: jha.ashray12, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
In this block in the LoginManagerParent, we have a debug log that is only applicable when the related realms pref is enabled. In order to prevent this log from polluting the rest of the logs with no information, it should be wrapped in a pref check for the signon.relatedRealms.enabled
preference.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help.
This will tell others that you're working on the next steps. - Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introduction
channel. They're there to help you get started. - You can also read the Developer Guide, which has answers to most development questions.
- If you have any problems, please ask on Element/Matrix in the
- Start working on this bug.
- As described on Comment #0, you will need to wrap the
debug
logging call in a if statement that checks to see if thesignon.relatedRealms.enabled
pref is enabled. The surrounding code should provide an example for you to work with. - If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the
#lockwise-desktop
channel on Element/Matrix most hours of most days.
- As described on Comment #0, you will need to wrap the
- Build your change with
mach build
and test your change withmach test toolkit/components/passwordmgr --headless
. Also check your changes for adherence to our style guidelines by usingmach lint
. - Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- How to Submit a Patch
- This is when the bug will be assigned to you.
- After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
- If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
- Your code will soon be shipping to Firefox users worldwide!
Assignee | ||
Comment 2•3 years ago
|
||
I want to work on this bug , will you please assign it to me. :)
Flags: needinfo?(tgiles)
Reporter | ||
Comment 3•3 years ago
|
||
Assigned, feel free to reach out if you have questions or need some guidance!
Assignee: nobody → jha.ashray12
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Attachment #9223852 -
Attachment description: WIP: Bug 1707074 - wrap debug logging for related realms feature in a pref check. r?tgiles → Bug 1707074 - wrap debug logging for related realms feature in a pref check. r?tgiles
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a0f0a14615b wrap debug logging for related realms feature in a pref check. r=tgiles
Comment 6•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•