Closed Bug 1707074 Opened 3 years ago Closed 3 years ago

Wrap debug logging for related realms feature in a pref check for said feature

Categories

(Toolkit :: Password Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: tgiles, Assigned: jha.ashray12, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

In this block in the LoginManagerParent, we have a debug log that is only applicable when the related realms pref is enabled. In order to prevent this log from polluting the rest of the logs with no information, it should be wrapped in a pref check for the signon.relatedRealms.enabled preference.

Mentor: tgiles
Severity: -- → N/A
Keywords: good-first-bug
Priority: -- → P3

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • As described on Comment #0, you will need to wrap the debug logging call in a if statement that checks to see if the signon.relatedRealms.enabled pref is enabled. The surrounding code should provide an example for you to work with.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/passwordmgr --headless. Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.

I want to work on this bug , will you please assign it to me. :)

Flags: needinfo?(tgiles)

Assigned, feel free to reach out if you have questions or need some guidance!

Assignee: nobody → jha.ashray12
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)
Attachment #9223852 - Attachment description: WIP: Bug 1707074 - wrap debug logging for related realms feature in a pref check. r?tgiles → Bug 1707074 - wrap debug logging for related realms feature in a pref check. r?tgiles
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a0f0a14615b
wrap debug logging for related realms feature in a pref check. r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: