1707177 - app menu badge for available update so tiny and blurry the arrow is unrecognizable

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: update available app menu badge

Firefox 90.0a1 20210422093115 on Windows 8.1 with 125% zoom on OS level

The app menu badge for an available update is so tiny and blurry that the arrow is unrecognizable.

Steps to reproduce:

1. Install not the latest build.
2. Disable automatic updates in the Settings (it might be necessary to start it with the -offline argument from the command line to be able to change this before it gets updated to the latest version).
3. Go online (Alt key > menu File).
4. Wait for update to get detected or trigger the background check (haven't the code at hand).

Comment 1

[katieC]

Attachment: Toolbar: Badges for FxA and App Menu icons

App menu and Fxa badges are simplified to small dot or triangle depending in the notification type (inside symbols removed). Please see attached mini spec for placement and details.
Circle/dot: notification-fill-12.svg
triangle: warning-fill-12.svg

Comment 2

[Emma Malysz]

We're going to need to introduce the new circle icon (notification-fill-12.svg), and make sure we use it here: https://searchfox.org/mozilla-central/rev/92be70819506d269df7c192bfbddc8c6ce581990/browser/themes/shared/customizableui/panelUI.inc.css#129

Comment 3

[Emma Malysz]

Attachment: Bug 1707177, introduce notification icon for app menu button badge and apply it when update available

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c196bec7eed9
introduce notification icon for app menu button badge and apply it when update available r=mhowell

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c196bec7eed9

Comment 6

[Pascal Chevrel:pascalc]

This is marked as priority2a, Is that something we should uplift to beta or do we let it ride the 90 train? Thanks

Comment 7

[Emma Malysz]

Since this is icon related work and low risk, I think it makes sense to request uplift

Comment 8

[Emma Malysz]

Comment on attachment 9219624 [details]
Bug 1707177, introduce notification icon for app menu button badge and apply it when update available

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes. Introduces an svg file and small css changes
• String changes made/needed: n/a

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9219624 [details]
Bug 1707177, introduce notification icon for app menu button badge and apply it when update available

Approved for 89 beta 9, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/66db631bc793

Comment 11

[Rares Doghi, Desktop QA]

Hi, I was trying to confirm the fix on this issue and it seems that only the update available Badge has been updated to the green dot displayed on the Hamburger menu.. but in the case for the Unable to Update notification the Exclamation mark is still displayed inside the badge for warning sign.

Is this bug strictly related to the Update available notifications ? cause from the screenshots in Comment 1 the Warning sign should not have the exclamation mark inside the badge.

I will add a screenshot of this case.

Comment 12

[Rares Doghi, Desktop QA]

Attachment: Screenshot 2021-05-10 at 17.00.27.png

Beta 89.0b9.

Comment 13

[Emma Malysz]

Hi Rares, this bug was just related to the update notification.

We're going to handle the warning icon in Bug 1707190.

Comment 14

[Rares Doghi, Desktop QA]

oh Awesome, This issue is Verified as fixed in our Latest Nightly and Beta 89.0b9 on Windows, Mac and Ubuntu.