Closed Bug 1707459 Opened 3 years ago Closed 3 years ago

Convert chatZilla from an extension

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53 unaffected, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 --- unaffected
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(3 files, 9 obsolete files)

Change chatZilla from being an extension to being part of SeaMonkey.

Attached patch 1707459-irc-embed-2538.patch (obsolete) — Splinter Review

This moves everything from suite/extensions/irc to suite/chatzilla
On l10n need to copy files in each locale from extensions/irc to suite/chatzilla
Things left to potentially do:

  • Change MOZ_IRC to MOZ_CHATZILLA
  • Reorganise the structure in suite/chatzilla to more closely match other parts of SeaMonkey

The above can always be done as follow-up bugs

Attachment #9218188 - Flags: feedback?(frgrahl)
Attached patch 1707459-irc-l10n-2538.patch (obsolete) — Splinter Review

Once chatZilla is no longer an extension we do not need to reference it in l10n.mk

Attachment #9218189 - Flags: review?(frgrahl)
Attachment #9218189 - Flags: approval-comm-release?
Attachment #9218189 - Flags: approval-comm-esr60?

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 2 strings removed

Maybe some changes needed in suite/installer/removed-files.in but that could be a follow-up patch.

Attachment #9218188 - Attachment is obsolete: true
Attachment #9218188 - Flags: feedback?(frgrahl)
Attachment #9218200 - Flags: review?(frgrahl)
Attachment #9218200 - Flags: approval-comm-release?
Attachment #9218200 - Flags: approval-comm-esr60?
Depends on: 1707458
Attached patch 1707459-irc-l10n-257.patch (obsolete) — Splinter Review
Attachment #9218189 - Attachment is obsolete: true
Attachment #9218189 - Flags: review?(frgrahl)
Attachment #9218189 - Flags: approval-comm-release?
Attachment #9218189 - Flags: approval-comm-esr60?
Attachment #9218768 - Flags: review?(frgrahl)
Attachment #9218768 - Flags: approval-comm-esr60?
Attached patch 1707459-irc-embed-v1_2-257.patch (obsolete) — Splinter Review
Attachment #9218200 - Attachment is obsolete: true
Attachment #9218200 - Flags: review?(frgrahl)
Attachment #9218200 - Flags: approval-comm-release?
Attachment #9218200 - Flags: approval-comm-esr60?
Attachment #9218769 - Flags: review?(frgrahl)
Attachment #9218769 - Flags: approval-comm-esr60?
Attached patch 1707459-irc-embed-v1_3-257.patch (obsolete) — Splinter Review

Fix typo whilst rebasing in suite/locale/Makefile.in

Attachment #9218769 - Attachment is obsolete: true
Attachment #9218769 - Flags: review?(frgrahl)
Attachment #9218769 - Flags: approval-comm-esr60?
Attachment #9218998 - Flags: review?(frgrahl)
Attachment #9218998 - Flags: approval-comm-esr60?
See Also: → 1604663
Depends on: 1604663
See Also: 1604663
OS: Unspecified → All
Hardware: Unspecified → All
Attached patch 1707459-irc-embed-v1_4-257.patch (obsolete) — Splinter Review

Make an incremental patch on top of Bug 1604663

Attachment #9218768 - Attachment is obsolete: true
Attachment #9218998 - Attachment is obsolete: true
Attachment #9218768 - Flags: review?(frgrahl)
Attachment #9218768 - Flags: approval-comm-esr60?
Attachment #9218998 - Flags: review?(frgrahl)
Attachment #9218998 - Flags: approval-comm-esr60?
Attachment #9222079 - Flags: review?(frgrahl)
Attachment #9222079 - Flags: approval-comm-esr60?
Attached patch 1707459-irc-embed-v1_4-cc.patch (obsolete) — Splinter Review

Patch for landing on comm-central, it will need a script to copy files in l10n-central from */extensions/irc to */suite/chatzilla for all locales that have extensions/irc
As far as I can tell the l10n.toml in suite/chatzilla/locales will only expose the strings in Pontoon to those locales that currently localise chatZilla

Attachment #9224145 - Flags: review?(frgrahl)

Fixed basepath issue in l10n.toml

Attachment #9222079 - Attachment is obsolete: true
Attachment #9222079 - Flags: review?(frgrahl)
Attachment #9222079 - Flags: approval-comm-esr60?
Attachment #9224549 - Flags: review?(frgrahl)
Attachment #9224549 - Flags: approval-comm-esr60?
Attached patch 1707459-irc-embed-v1_5-cc.patch (obsolete) — Splinter Review

Fixed paths in l10n.toml and removed unneeded extension hacks in suite/locales/*

Attachment #9224145 - Attachment is obsolete: true
Attachment #9224145 - Flags: review?(frgrahl)
Attachment #9224550 - Flags: review?(frgrahl)

Include DEFINES['CHATZILLA_VERSION'] which will get used when bug 1712509 lands on cc.

Attachment #9224550 - Attachment is obsolete: true
Attachment #9224550 - Flags: review?(frgrahl)
Attachment #9224555 - Flags: review?(frgrahl)

Comment on attachment 9224555 [details] [diff] [review]
1707459-irc-embed-v1_6-cc.patch

LGTM

Attachment #9224555 - Flags: review?(frgrahl) → review+
See Also: → 1606400

Tested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.

What is the best way to notify dev-l10n now, via discourse?

Attachment #9226687 - Flags: review?(francesco.lodolo)

Comment on attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bash

I will have to rewrite this to adapt it to my scripts, but it seems reasonable.

Attachment #9226687 - Flags: review?(francesco.lodolo) → review+

(In reply to Ian Neal from comment #13)

Created attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bash

Tested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.

Not sure what you mean? All locales will find these string in SM, those who translated the old add-on will find them already translated.

What is the best way to notify dev-l10n now, via discourse?

Yes, and the Matrix channel.

(In reply to Francesco Lodolo [:flod] from comment #15)

(In reply to Ian Neal from comment #13)

Created attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bash

Tested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.

Not sure what you mean? All locales will find these string in SM, those who translated the old add-on will find them already translated.

I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers

(In reply to Ian Neal from comment #16)

I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers

No, that's not used for hg projects, it's only used for build/automation

(In reply to Francesco Lodolo [:flod] from comment #17)

(In reply to Ian Neal from comment #16)

I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers

No, that's not used for hg projects, it's only used for build/automation

Okay, that's fine. Ready for the l10n copy to happen when you are.

(In reply to Ian Neal from comment #18)

(In reply to Francesco Lodolo [:flod] from comment #17)

(In reply to Ian Neal from comment #16)

I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers

No, that's not used for hg projects, it's only used for build/automation

Okay, that's fine. Ready for the l10n copy to happen when you are.

This needs to land in comm-central and go through the cross-channel generation (which is automated), for me to be able to run the copy.

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d176681b6bce
Convert chatZilla from an extension. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9224549 [details] [diff] [review]
1707459-irc-embed-v1_5-257.patch

LGTM nits addressed in v1.6

Attachment #9224549 - Flags: review?(frgrahl)
Attachment #9224549 - Flags: review+
Attachment #9224549 - Flags: approval-comm-esr60?
Attachment #9224549 - Flags: approval-comm-esr60+
Target Milestone: --- → seamonkey 2.88

Script is running, should be done in about 30 minutes, then I'll re-enable Sync in Pontoon.

Test run on Italian
https://hg.mozilla.org/l10n-central/it/rev/be38bd5a89d6ba38d771fd7c25cbf049ba49360f

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: