1707560 - don't scroll to the top if double tap on very tall element that is > 90% the width of the viewport

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

We have code for this, it's disabled for elements that are 90% or greater the width of the viewport. This code was added in bug 1204084 for the "double tap on tall element" problem and the 90% hasn't been touched since. I can't think of a good reason why we would want to scroll to the top of the element if its 90% the width of the viewport or more.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1707560. Don't scroll to the top if double tap on very tall element that is > 90% the width of the viewport. r?botond

We have code for this, it's disabled for elements that are 90% or greater the width of the viewport. This code was added in bug 1204084 for the "double tap on tall element" problem and the 90% hasn't been touched since. I can't think of a good reason why we would want to scroll to the top of the element if its 90% the width of the viewport or more.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1707560. Add test. r?botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ec725406db0
Don't scroll to the top if double tap on very tall element that is > 90% the width of the viewport. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e42509d1b5a0
Add test. r=botond

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0ec725406db0
https://hg.mozilla.org/mozilla-central/rev/e42509d1b5a0

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9218316 [details]
Bug 1707560. Don't scroll to the top if double tap on very tall element that is > 90% the width of the viewport. r?botond

Beta/Release Uplift Approval Request

• User impact if declined: double tap zoom on tall and wide elements scrolls to the top, which is not what users expect
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): only changes double tap to zoom code
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218316 [details]
Bug 1707560. Don't scroll to the top if double tap on very tall element that is > 90% the width of the viewport. r?botond

Approved for 89 beta 7, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a852846b1706
https://hg.mozilla.org/releases/mozilla-beta/rev/98614d59fa54