1707569 - Addressbook CardDav sync from Google duplicates modified addresses

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Sjoko]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Using a CardDav Google adressbook.
Modifying a simple contact on the serverside (through google contacts in browser), I modified the firstname and the lastname.
This simple contact consists of o firstname and a lastname only.
Hitting synchronize (right-click on addressbook and select synchronize).

Using thunderbird beta 88.0b3 on windows10 pro.

Actual results:

The addressbook entry in thunderbird was duplicated.
Both the old version and the new version are visible.
When I deleted either one, both disapear, also from the serverside.

Expected results:

Only the modified version of the contact should be visible in thunderbird. No duplication!
( Modifications in thunderbird sync to the server works fine, produce no duplicates. )

Comment 1

[Geoff Lankow (:darktrojan)]

This might be a duplication in the display rather than of the contact itself. What happens if you close and reopen the address book window?

Comment 2

[Sjoko]

I restarted Thunderbird, re-synchronized by right-click-synchronize on the addressbook, but things do not get better.
Currently, the contact list in thunderbird does not match the one in gmail-contacts,
Modifying an existing one in gmail-contacts lead to the appearance the modified one in thunderbird with the original one still visible.
Sorry, but this does not work at all.

Comment 3

[Geoff Lankow (:darktrojan)]

Aha!, I did something different and I can see the problem now.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

Before this patch, if the server changed a card's UID when it arrived, we continued to use the old UID. This caused problems when updating cards.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4700ee58d4e2
Correctly store a card if the CardDAV server changes the UID. r=mkmelin

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9220010 [details]
Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): never worked as intended
User impact if declined: address book gets confused about new contacts for some server behaviour (Google at least)
Testing completed (on c-c, etc.): just landed, I'd like it on Daily for a week or so before beta
Risk to taking this patch (and alternatives if risky): I think it's low risk

Comment 7

[Geoff Lankow (:darktrojan)]

Thanks for reporting this, Sjoko.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9220010 [details]
Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

[Triage Comment]
Approved for beta ... which will happen ~mid-week

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/8e9895e52538

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/e4541b3bc452

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/76e381a64fa4

Comment 12

[Magnus Melin [:mkmelin]]

Uplift to 78 I suppose?

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9220010 [details]
Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

Yeah, alright.

[Approval Request Comment]
Regression caused by (bug #): never worked as intended
User impact if declined: address book gets confused about new contacts for some server behaviour (Google at least)
Testing completed (on c-c, etc.): in beta 4
Risk to taking this patch (and alternatives if risky): I think it's low risk

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9220010 [details]
Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 15

[Rob Lemley [:rjl]]

Comment on attachment 9220010 [details]
Bug 1707569 - Correctly store a card if the CardDAV server changes the UID. r?mkmelin

CardDAVServer.jsm on esr78 is quite a bit older than beta, so this didn't merge right.

Specifically, isRealDirectory from bug 1692279 is missing, but so is every other change in between.

Comment 16

[Geoff Lankow (:darktrojan)]

Attachment: 1707569-esr78.diff

Here's a version for 78. Bug 1695592 should get uplifted (ahead of this) but not the others because they're too complicated.

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 78.11.0:
https://hg.mozilla.org/releases/comm-esr78/rev/07e12d832621