1707589 - Tracking protection settings details are not aligned with the header above them

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[:Gijs (he/him)]

Attachment: Misaligned example

This regressed in two steps:

1. bug 1701448 ( https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1e18de5001bc4cf4636b19b0c891403172a5be8c&tochange=06b1ac14775250a1e95c0c1324fd7aee8fe5cc57 ) made the gap about 2 CSS px
2. bug 1704027 ( https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b1695cda8cf952331addc65abafaae9997fedfce&tochange=667202e3a44d177719c25a9bba9e4c6cf2322e41 ) made the gap wider still.

I see this on both Windows and macOS.

Comment 1

[Julien Wajsberg [:julienw]]

FYI I see this on Linux as well.

Comment 2

[Itiel]

Attachment: Bug 1707589 - Fix indentation of sub-text in about:preferences to reflect the new checkboxes and radiobuttons sizes r?gijs

This includes:

1. Changing the indent from 28px to 22px (radiobutton/checkbox's 16px + 6px margin)
2. Unifying all .checkbox-icon to 2px (which was already the case, just duplicated on all platforms) only when a src is present
3. Removing a seemingly obsolete -1px margin-inline-start from .radio-label-box

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a397d8a14ea
Fix indentation of sub-text in about:preferences to reflect the new checkboxes and radiobuttons sizes r=Gijs,preferences-reviewers

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3a397d8a14ea

Comment 5

[Harry Twyford]

Attachment: Screen Shot 2021-04-29 at 10.17.26 AM.png

What was the rationale for removing the margin-inline-end on checkbox[native]? It makes checkboxes and their labels look a little too tight imo.

Comment 6

[Itiel]

(In reply to Harry Twyford [:harry] from comment #5)

Created attachment 9219223 [details]
Screen Shot 2021-04-29 at 10.17.26 AM.png

What was the rationale for removing the margin-inline-end on checkbox[native]? It makes checkboxes and their labels look a little too tight imo.

Thanks, filed as bug 1708525.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey Itiel, what do you think the risk is for uplifting this and bug 1708525 to beta? Or do you feel like we should wontfix for 89, and let these fixes ride in 90?

Comment 8

[Itiel]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #7)

Hey Itiel, what do you think the risk is for uplifting this and bug 1708525 to beta? Or do you feel like we should wontfix for 89, and let these fixes ride in 90?

If QA could first test that checkboxes/radiobuttons have reasonable (pretty vague, I know) spacing between them and their labels across Nightly it'd be great.
The screenshot in the description seems jarring, but I'm hesitant to uplift this after seeing it had caused bug 1708525...

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regression caused by this fix.

For more information, please visit auto_nag documentation.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Putting it on QA radar to verify in nightly.

Comment 11

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the issue on Firefox 90.0a1 (2021-04-26) under macOS 10.15.7 by following the info provided on Comment 0.

This issue is fixed on Firefox 90.0a1 (2021-05-30). Tests were performed on macOS 10.15.7, Ubuntu 20.04 and Windows 10.