1707591 - Update to black 21.11b1

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

There is a new version of black ( https://github.com/psf/black/releases/tag/21.4b0 ). We should use it.

The patch will look like:
https://hg.mozilla.org/mozilla-central/rev/c905933ae261
and might require a reformat of the tree like in
https://hg.mozilla.org/mozilla-central/rev/f5216758d874

Comment 1

[:gerard-majax]

As per bug 1740629 this might be a bit more urgent now?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - Update to black 21.11b1 r?#linter-reviewers,gerard-majax

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - ride along - reformat the tree with black 21.10b0 r?ahal

This changed with this:
https://github.com/psf/black/pull/1740

Depends on D130964

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0269849fd7ef
Update to black 21.10b0 r=gerard-majax
https://hg.mozilla.org/integration/autoland/rev/a730ab2d0dbe
ride along - reformat the tree with black 21.10b0 r=webdriver-reviewers,whimboo,gerard-majax

Comment 5

[Iulian Moraru]

Backed out for causing python mozlint failures on test_yaml.py.

Push with failures

Failure log

Backout link

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - pylint: update typed-ast as it is breaking black's req r?#linter-reviewers,gerard-majax

See https://bugzilla.mozilla.org/show_bug.cgi?id=1707591#c5

Depends on D130964

Comment 7

[Sylvestre Ledru [:Sylvestre]]

The error is
[task 2021-11-12T16:19:42.726Z] 0:59.36 Unable to match yaml regex against output: black 21.10b0 has requirement typed-ast>=1.4.2; python_version < "3.8", but you have typed-ast 1.4.1.

Comment 8

[Takanori MATSUURA]

21.1b1 has been released.
https://github.com/psf/black/releases/tag/21.11b1

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - Parse the new output of black --version r?#linter-reviewers,gerard-majax

Depends on D126202

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - ride along: update of the pylint dep to match black's r?#linter-reviewers,gerard-majax

Depends on D130964

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1707591 - ride along: update of the flake8 dep to match black's r?#linter-reviewers,gerard-majax

Depends on D131717

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45dae660af98
Parse the new output of black --version r=linter-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/3829d10ed633
Update to black 21.11b1 r=gerard-majax
https://hg.mozilla.org/integration/autoland/rev/f105477d372d
ride along - reformat the tree with black 21.10b0 r=ahal,webdriver-reviewers,perftest-reviewers,whimboo,gerard-majax,alexandru.irimovici
https://hg.mozilla.org/integration/autoland/rev/05fa7ff67318
ride along: update of the pylint dep to match black's r=linter-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/3de4e3bcca1c
ride along: update of the flake8 dep to match black's r=linter-reviewers,ahal

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Seems that we will be good
https://treeherder.mozilla.org/jobs?repo=autoland&revision=3de4e3bcca1c1fc84fdc5c1076469292a03e8a3a

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/45dae660af98
https://hg.mozilla.org/mozilla-central/rev/3829d10ed633
https://hg.mozilla.org/mozilla-central/rev/f105477d372d
https://hg.mozilla.org/mozilla-central/rev/05fa7ff67318
https://hg.mozilla.org/mozilla-central/rev/3de4e3bcca1c