Open Bug 1707625 Opened 4 years ago Updated 4 years ago

Spaces get mangled in option arguments passed through run_task.py on Windows only

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task

Tracking

(Not tracked)

People

(Reporter: sfink, Unassigned)

Details

I did some horrible platform-specific hackery in testing/raptor/raptor/manifest.py over in bug 1702310 because the command line is not properly passed through to the command.

The better way to do this is to pass the arguments as a list. I believe this is not being done because we want $VAR substitutions to occur, as I recall reading... somewhere?

But the way it's done now means that we depend on command-line parsing to not mess up the arguments, which is very brittle. I don't know how much work it would be, but it seems like it'd be better to either (1) don't allow $VAR to make it this far, or (2) do the $-substitution manually in run_task.py and pass through a list. (2) might be easy, if it can be guaranteed to have the needed env vars already in the configuration at the time the command is being assembled? Which probably isn't the case.

There are other possibilities as well, but those were the first that came to mind.

Summary: Spaces mangle options passed through run_task → Spaces get mangled in option arguments passed through run_task.py on Windows only
You need to log in before you can comment on or make changes to this bug.