1707627 - Info button from profiler very hard to see when hovered over

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Bogdan Maris, Desktop QA]

Affected versions

• Firefox 89.0b4
• Latest Nightly 90.0a1
• Firefox 88.0

Affected platforms

• Ubuntu 18.04

Steps to reproduce

1. Start Firefox
2. Add profiler into the toolbar (for non Nightly)
   2.1 Visit https://profiler.firefox.com
   2.2 Click Enable Firefox Profiler Menu Button
3. Click the dropdown button from Profiler
4. Have the Dark theme enabled in Firefox
5. Hover over the info icon (when the menu is minimized, blue background hidden)

Expected result

• Info icon can be seen when hovering over.

Actual result

• Info icon is barely visible when hovering.

Regression range

• First bad: 647b17e76dd85ea84716a62726b916887bee2c86
• Last good: 811527c596f4100a075c490606ea602ce5a6b7b5
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=811527c596f4100a075c490606ea602ce5a6b7b5&tochange=647b17e76dd85ea84716a62726b916887bee2c86
• Potential regressor: Bug 1667646 - Unify the info button's hover and active design for the bookmarks CFR and the protections popup

Additional notes

• The good build from the above regression had white background when hovering and the 'bad' build changed into grey dark hover. With proton, the hover effect has the same or almost the same color as the panel making the icon very hard to see.
• Probably this is an issue because the info icon changes color to a dark grey.

Suggested severity

• Since probably not many people use profiler, the impact of this would be fairly low. I would suggest S3 severity.

Comment 1

[Bogdan Maris, Desktop QA]

Attachment: Gif showing the issue

Comment 2

[Itiel]

Can you please verify that this happens also on the protections popup UI, when hovering the same button?

Comment 3

[Bogdan Maris, Desktop QA]

(In reply to Itiel from comment #2)

Can you please verify that this happens also on the protections popup UI, when hovering the same button?

I can only see this issue with profiler icon, protections popup info icon looks visible.

Comment 4

[Itiel]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #3)

(In reply to Itiel from comment #2)

Can you please verify that this happens also on the protections popup UI, when hovering the same button?

I can only see this issue with profiler icon, protections popup info icon looks visible.

Thanks!

Comment 5

[Itiel]

Attachment: Bug 1707627 - Fix the panel info icon color on Linux r?dao

Comment 6

[Tyler Duzan]

This looks like the issue existed in 88 Release? I am not sure this an MR1 related regression.

Comment 7

[Bogdan Maris, Desktop QA]

(In reply to Tyler Duzan from comment #6)

This looks like the issue existed in 88 Release? I am not sure this an MR1 related regression.

Not sure if this is a question or not but the answer is yes, 88.0 is also affected by this.

Comment 8

[Itiel]

:bogdan_maris, can you re-test on a current Nightly if this is still an issue? I think bug 1710415 has fixed this.

Comment 9

[Bogdan Maris, Desktop QA]

I can't reproduce it anymore using latest Nightly 92.0a1 on Windows 10. Marking as Worksforme.