Closed Bug 1707682 Opened 4 years ago Closed 4 years ago

Bump up GPU process max restarts.

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox88 --- wontfix
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We've been using 3 on Nightly for a long time without
any problems and it's generally much better to keep the GPU
process around than give up on it.

We also bump the Nightly value to increase the chances of us
finding any problems where we should give up on using the GPU process.

We've been using 3 on Nightly for a long time without
any problems and it's generally much better to keep the GPU
process around than give up on it.

We also bump the Nightly value to increase the chances of us
finding any problems where we should give up on using the GPU process.

Blocks: 1707596
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5b6143d6c01 Bump up GPU process max restarts. r=aosmond

Comment on attachment 9218426 [details]
Bug 1707682 - Bump up GPU process max restarts.

Beta/Release Uplift Approval Request

  • User impact if declined: Reduced stability because we fall back to doing a bunch of graphics stuff in the parent process
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is just a pref change that causes us to retry using the gpu process 3 times instead of once.
  • String changes made/needed:
Attachment #9218426 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9218426 [details]
Bug 1707682 - Bump up GPU process max restarts.

Beta/Release Uplift Approval Request

  • User impact if declined: Users lose GPU acceleration if the GPU process crashes. These are much more likely then they used to be because 2d canvas and WebGL have both mvoed to the GPU process. Having this fixed on release in 88 will be very useful for planing our WebRender rollout in 89
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It lets the GPU process start 3 times instead of 1 it's unlikely having this happen would cause anything catastrophic and it's been that way on Nightly for many years.
  • String changes made/needed:
Attachment #9218426 - Flags: approval-mozilla-release?

Comment on attachment 9218426 [details]
Bug 1707682 - Bump up GPU process max restarts.

Looks low risk enough and we are in early betas still, approved for 89 beta 9, thanks.

Attachment #9218426 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9218426 [details]
Bug 1707682 - Bump up GPU process max restarts.

Fx89 is in RC now, no need to take in 88.

Attachment #9218426 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: