Closed Bug 1707756 Opened 7 months ago Closed 7 months ago

Search nudge "Ok, got it" button should use proton primary button styles

Categories

(Firefox :: Theme, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox89 + verified
firefox90 --- verified

People

(Reporter: ntim, Assigned: harry)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar], [proton-icons] [proton-uplift])

Attachments

(3 files)

Attached image image.png
No description provided.
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 90.1 - Apr 19 - May 2
Points: --- → 2

Depends on D113530

Setting P1 only because this patch updates an icon. Afaik, all icon patches are P1.

Priority: -- → P1

[Tracking Requested - why for this release]:
Part 1 is CSS-only and updates a UI element that's seen quite often to Proton styling.
Part 2 is an icon patch, which is high priority for Proton.

I'll request uplift tomorrow, after I verify in Nightly.

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be804f37dfe3
Part 1 - Update Urlbar tips to Proton styles. r=mak,dao
https://hg.mozilla.org/integration/autoland/rev/ddfb12358dcd
Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a68ceee155
Backed out 2 changesets for causing build bustages. CLOSED TREE
Flags: needinfo?(htwyford)
Whiteboard: [proton-address-bar] → [proton-address-bar], [proton-icons]
Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/703bb6b1d811
Part 1 - Update Urlbar tips to Proton styles. r=mak,dao
https://hg.mozilla.org/integration/autoland/rev/6c256f8029d9
Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski

Comment on attachment 9218679 [details]
Bug 1707756 - Part 1 - Update Urlbar tips to Proton styles. r?mak,dao

Beta/Release Uplift Approval Request

  • User impact if declined: Fairly high-profile button will be using pre-Proton styling. Part 2 uplifts a Proton icon.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Set browser.urlbar.searchTips.test.ignoreShowLimits to make testing easier.
  1. Go to about:home and observe that the button in the Search Tip below the Urlbar has Proton styling.
  2. Set your default search engine to Google and go to google.com. Observe that the button in the Search Tip below the Urlbar has Proton styling.
  3. Type "update firefox" in the address bar. Observe that the button in the second result has Proton styling.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only, affecting only these particular buttons in some Urlbar results.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9218679 - Flags: approval-mozilla-beta?
Attachment #9218680 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-address-bar], [proton-icons] → [proton-address-bar], [proton-icons] [proton-uplift]

Comment on attachment 9218679 [details]
Bug 1707756 - Part 1 - Update Urlbar tips to Proton styles. r?mak,dao

Low risk css +svg patch, approved for 89 beta 8, thanks.

Attachment #9218679 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9218680 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I reproduced this issue using Fx 89.0a1(2021-04-19) on macOS 10.13.6.
I can confirm this issue is fixed; I verified using Fx 90.0a1(2021-05-05) and Fx 89.0b8 on macOS 10.13.6, Ubuntu 20.04 LTS and Windows 10 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.