1707875 - [Proton] Inconsistent bookmarks panel field and button colors on Linux

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Andrew]

Attachment: Screenshot

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Visited any webpage and clicked the bookmark icon in the urlbar, opening a pop-up menu.

Actual results:

Some elements in the popup follow the current Firefox theme while others follow the Operating system's theme. This is most visible when using a dark Operating System theme and a light Firefox theme (or vice-versa). The Cancel button also seems to follow the Firefox theme, but the text color on this button follows the Operating System theme on hover, making the text nearly invisible when hovering on the button with certain theme combinations.

Expected results:

All elements in the bookmark page popup should consistently follow the current Firefox theme.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Drew Willcoxon :adw]

Thanks for reporting this. I tested all the combinations of Ubuntu and Firefox themes with the latest m-c, and the following colors/combinations are wrong:

• Standard Ubuntu theme + dark Firefox: "Remove bookmark" button hover
• Dark Ubuntu theme + light Firefox: Field background color, "Remove bookmark" button hover
• Light Ubuntu theme + dark Firefox: "Remove bookmark" button hover

Comment 3

[Andrew]

I'm not sure if this should be made into another bug report, but regarding the issue with the "Remove bookmark"/"Cancel" buttons, I have also noted a few other elements in the browser that have the same issue. So far, I have found the same issue with the up/down arrows in the find bar and the "Clear Cookies and Site Data" & "More Information" buttons in the site information popup.

In most similar buttons in the browser, text and sometimes icons are given the color 'currentColor'. I have noticed that in all of the mentioned occurrences with buttons using the wrong text colors when hovered, the buttons have some extra CSS that causes the color or fill to be set to '-moz-buttonhovertext' on hover. Most other buttons in Firefox that don't have this issue simply don't have that extra CSS code (or override it somewhere). Adding a switch in each corresponding CSS code section that causes the code to fire only when proton is enabled should fix this issue. At the moment, adding this switch to button.css (line 33) and toolbarbutton.css (line 37) seems to fix all known occasions of incorrect hovered text colors without any negative impacts.

The other issue regarding the background colors will probably be more involved, though.

Comment 4

[Tyler Duzan]

This may be in some way related to 1708428 I also noticed some oddities with dark theme and the bookmarks panel on macOS during my PM review. I'm going to mark this as a P2a, although I don't think it'll be fixed in time for 89. I'd like to see this fixed in 90 though.

Comment 5

[:Gijs (he/him)]

I keep not getting to this, so going to drop this.

Comment 6

[Itiel]

(In reply to Drew Willcoxon :adw from comment #2)

Thanks for reporting this. I tested all the combinations of Ubuntu and Firefox themes with the latest m-c, and the following colors/combinations are wrong:

• Standard Ubuntu theme + dark Firefox: "Remove bookmark" button hover
• Dark Ubuntu theme + light Firefox: Field background color, "Remove bookmark" button hover
• Light Ubuntu theme + dark Firefox: "Remove bookmark" button hover

I'm not seeing these issues anymore, do you?

Comment 7

[Drew Willcoxon :adw]

Thanks Itiel, I can't reproduce this anymore either.