Closed
Bug 1707962
Opened 3 years ago
Closed 3 years ago
Clear highlighters on target switching
Categories
(DevTools :: Inspector, enhancement)
DevTools
Inspector
Tracking
(Fission Milestone:M8, firefox91 fixed)
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
HighlighterOverlay memoize its Inspector Front as well as the target Front, and listen to will-navigate only on the one target received in the constructor.
All of that breaks when we navigate to a new target. A couple of tests related to grid and rule view fails because of that when enabling bug 1698891.
(ex: devtools/client/inspector/grids/test/browser_grids_restored-after-reload.js)
https://searchfox.org/mozilla-central/rev/6cbe34b441f7c7c29cd1e5f0e19c7000142f1423/devtools/client/inspector/shared/highlighters-overlay.js#121-123
https://searchfox.org/mozilla-central/rev/6cbe34b441f7c7c29cd1e5f0e19c7000142f1423/devtools/client/inspector/shared/highlighters-overlay.js#222
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Updated•3 years ago
|
Whiteboard: dt-fission-m3-triage
|
||
Updated•3 years ago
|
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
|
|
||
Updated•3 years ago
|
Fission Milestone: --- → M8
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
||
Updated•3 years ago
|
Attachment #9218707 -
Attachment description: Bug 1707962 - Fix highlighter overlays on target switch → Bug 1707962 - Fix highlighter overlays on target switch. r=ochameau.
|
|
||
Updated•3 years ago
|
Attachment #9218707 -
Attachment description: Bug 1707962 - Fix highlighter overlays on target switch. r=ochameau. → Bug 1707962 - [devtools] Fix highlighter overlays on target switch. r=ochameau.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f3fd0383426 [devtools] Fix highlighter overlays on target switch. r=ochameau.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•