170797 - bookmark group is imported as a folder

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[sairuh (rarely reading bugmail)]

found while testing bug 166203, using 2002.09.25.04. when importing a bookmarks
file (in html format) which contains a bookmark group, that groups ends up as a
folder instead.

sample bookmarks.html coming up...

Comment 1

[sairuh (rarely reading bugmail)]

Attachment: sample bookmarks.html with bm group in PT folder

the bookmark group here is called "group1" (consisting of 3 tabs), and is
located in the Personal Toolbar folder.

1. save this file locally.
2. select Manage Bookmarks > Import Bookmarks...
3. select the file and click "open"
4. go to the bookmarks sidebar, and open the imported items ("Mozilla/Netscape
Favorites"). alternatively, look at the Bookmarks toplevel menu.

observe that "group1" is now a folder, not bookmark group.

Comment 2

[Ray Charbonneau]

Another way to turn a bookmark group into a folder is to open the bookmark
manager and cut (or copy)-and-paste the bookmark group.  You can drag a group
around, and it'll stay a group, but if you cut/copy and paste the group, it
becomes a folder.

I'm testing on Windows 2000/SP3:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030202

Comment 3

[David Haas (gone, not reading mail)]

Attachment: patch

sets group flag.

Comment 4

[David Haas (gone, not reading mail)]

move to pink, add to cleanup bug

Comment 5

[David Haas (gone, not reading mail)]

Attachment: multi-patch

also fixes bug 199651, and an import crash if Mozilla/Netscape file had a menu
spacer.

Comment 6

[S Woodside]

Comment on attachment 136326 [details] [diff] [review]
multi-patch

works as advertised.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 136326 [details] [diff] [review]
multi-patch

sr=pink

Comment 8

[Mike Pinkerton (not reading bugmail)]

landed