1708010 - temperature conversion in addressbar/urlbar wrong, e.g. °C (Celsius) to °F (Fahrenheit) uses wrong formula

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:
Wrong temperature conversion in new feature for en-US.

Steps to reproduce:

1. Set browser.urlbar.suggest.calculator to true.
2. Type this into the address bar: 30C in F

Actual result: 111.6°F
Expected result: 86°F

Reason for the difference:
The formula is T[C] * 1.8 + 32. Firefox uses (T[C] + 32) * 1.8.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1708010 - fix temperature conversion from Celsius to Fahrenheit. r=daisuke

Code got added in bug 1697722.

Comment 2

[Drew Willcoxon :adw]

Thanks for noticing and patching, but this doesn't need to track. The unit converter is experimentally enabled only on Nightly, and we don't have plans to enable it more broadly any time soon. I'll take the triage owner's prerogative and cancel the request.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f26f291d34b
fix temperature conversion from Celsius to Fahrenheit. r=daisuke

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f26f291d34b

Comment 5

[Pablo]

verified fix on WIndows10, ubuntu 20 and Mac 10.15
with release 89, beta 90.0b1 and Nightly 91.0a1

in all cases urlbar showed 86