1708015 - Replace MOZ_USE_NATIVE_POPUP_WINDOWS with mozilla::widget::NativeMenuSupport::ShouldUseNativeContextMenus() in nsToolkit.mm

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Stephen A Pohl [:spohl]]

We have some dead code in widget/cocoa that uses the compile-time define MOZ_USE_NATIVE_POPUP_WINDOWS to check whether native context menus are enabled. We should do away with this code and replace it with the runtime check mozilla::widget::NativeMenuSupport::ShouldUseNativeContextMenus(). I am making the first of these replacements in bug 1707869 where this change results in a fix for a regression introduced by the enabling of native context menus. However, replacing this compile-time define with a runtime check could introduce other regressions, which is why I'm breaking this out into a separate bug and patch for easier tracking and/or backout if necessary.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1708015: Replace MOZ_USE_NATIVE_POPUP_WINDOWS with mozilla::widget::NativeMenuSupport::ShouldUseNativeContextMenus() in nsToolkit.mm. r=mstange

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1b7e7a7cc3
Replace MOZ_USE_NATIVE_POPUP_WINDOWS with mozilla::widget::NativeMenuSupport::ShouldUseNativeContextMenus() in nsToolkit.mm. r=mstange

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bb1b7e7a7cc3