1708212 - Remove the menuitem-iconic class where we don't add icons

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We have now a lot of menuitems defined to use the menuitem-iconic class albeit we don't add icons to them.

Removing them makes it easier to define rules for the Photon Windows 10 menu rules. And it could be that creating the menus is faster as less elements have to be added.

I'll also add a rule to show the space on the left of the menus always like the default menus do.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1708212-remove-menuitem-iconic.patch

John, I added you as ui-r so you can check if this is better for you on Windows 10.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9218962 [details] [diff] [review]
1708212-remove-menuitem-iconic.patch

Review of attachment 9218962 [details] [diff] [review]:
-----------------------------------------------------------------

This is good, I think.
I'm not a heavy user of the menu bar (I actually don't use it at all), so I'd prefer to have an extra review on this from someone that uses it.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9218962 [details] [diff] [review]
1708212-remove-menuitem-iconic.patch

It was more for a code review as John is doing the ui-r.

Magnus, can you look at it? On Linux you shouldn't see any changes except the smiley menu in composer.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1708212-remove-menuitem-iconic.patch

Updated the reviewer in the commit message and fixed the padding in menulist popups on Windows 10.

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9219558 [details] [diff] [review]
1708212-remove-menuitem-iconic.patch

Looks good! All menus I was able to test appear as expected.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c17d62590bff
Remove the menuitem-iconic class where we don't add icons. r=mkmelin ui-r=TBSync