1708217 - Align font size on privacy and information panels with application menu font size

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[Romain Testard [:RT]]

Attachment: panels.gif

As a result of bug 1706415 font size decrease on all panels but the information and protection panels.

Acceptance criteria:

• Font size on information and protection panels algn with font size on other panels.

Comment 1

[:Gijs (he/him)]

I think this is the result of a conflict with the patch from bug 1700957 that broke things and that I spotted in the last hour; that patch has been backed out already.

Can you check with this build: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/au4VSszURdy8rmTgDqIwVg/runs/0/artifacts/public/build/target.zip and check if it is fixed there?

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #1)

I think this is the result of a conflict with the patch from bug 1700957 that broke things and that I spotted in the last hour; that patch has been backed out already.

Can you check with this build: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/au4VSszURdy8rmTgDqIwVg/runs/0/artifacts/public/build/target.zip and check if it is fixed there?

to be clear, opt windows builds have not yet finished for the backout, this is an m-c build from https://treeherder.mozilla.org/jobs?repo=mozilla-central&selectedTaskRun=au4VSszURdy8rmTgDqIwVg.0&revision=3c313de2c7d531be21cad167fe641a217fe2bf1c which I believe doesn't include the patch from bug 1700957, but does include the patch from bug 1706415.

Comment 3

[Romain Testard [:RT]]

The build from comment 1 does not adjust the protections and information panels font size unfortunately.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

We've identified this rule, which the original patch had removed: https://hg.mozilla.org/mozilla-central/file/e01ec8694924852acd5a4632c23f9dc8a6b19858/browser/themes/shared/controlcenter/panel.inc.css#l17

I think what we want to do here is to set font: menu if Proton is enabled, and if not, use this old rule. Going to test that out now.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1708217 - Use font: menu for Site Permission, Protections and Control Center panels. r?Gijs!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Testing this across Windows 10, Windows 7 and Ubuntu still, and then I'll request review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2b2906acc70
Use font: menu for Site Permission, Protections and Control Center panels. r=Gijs

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e2b2906acc70

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9218985 [details]
Bug 1708217 - Use font: menu for Site Permission, Protections and Control Center panels. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low-risk CSS-only change that affects the fonts used in 3 panels.
• String changes made/needed: None.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218985 [details]
Bug 1708217 - Use font: menu for Site Permission, Protections and Control Center panels. r?Gijs!

Approved for 89 beta 7, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef6aead270a6