Flip Preference for Private Fields
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
Just about ready to flip the private fields pref; just waiting for the intent-to-ship to arrive on dev-platform!
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
As well, convert --enable-private-fields to --disable-private-fields
Depends on D113704
|
||
Updated•3 years ago
|
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26e29ac0e610 Enable Private Fields Preference by default r=yulia,robwu https://hg.mozilla.org/integration/autoland/rev/48fb4213beb9 Remove shell flag requirement for private field tests r=yulia
|
||
Comment 4•3 years ago
|
||
Backed out for causing build bustages: https://hg.mozilla.org/integration/autoland/rev/1c71de621cd037eb72b92148bbdc73e54f5e11f4
Failure log: https://treeherder.mozilla.org/logviewer?job_id=338323350&repo=autoland&lineNumber=23552
https://treeherder.mozilla.org/logviewer?job_id=338324195&repo=autoland&lineNumber=3261
|
|
Assignee | |
Comment 5•3 years ago
|
||
This test was added in Bug 1651420, and then broken silently, due to an error
in the activation of the test by Bug 1653567. This edge case behaviour
shouldn't block us from landing private fields and methods
Tracking fixing this I have opened Bug 1708812.
|
|
Assignee | |
Updated•3 years ago
|
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/025918cd3e0e Remove broken console-instant-eval test r=evilpie https://hg.mozilla.org/integration/autoland/rev/9d8e1850efbb Enable Private Fields Preference by default r=yulia,robwu https://hg.mozilla.org/integration/autoland/rev/c358155447a9 Remove shell flag requirement for private field tests r=yulia
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/025918cd3e0e
https://hg.mozilla.org/mozilla-central/rev/9d8e1850efbb
https://hg.mozilla.org/mozilla-central/rev/c358155447a9
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 8•3 years ago
|
||
FYI FF90 Docs for this are pretty much complete.
- Eric Meyer did a huge update in https://github.com/mdn/content/pull/5690 for this - check out in particular Private class features and Working with private class features
- Release notes updated (note, that will change slightly to "Private class static and instance fields and methods" are supported by default).
- Preference has been removed from experimental features.
Description
•