1708240 - [css-fonts-5] font-size-adjust: from-font

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#5539.

[css-fonts-5] font-size-adjust: auto

• RESOLVED: add from-font keyword to font-size-adjust

Discussion.

Comment 1

[Thomas Wisniewski [:twisniewski]]

The Safari 17 beta now supports this.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1708240 - Adjust margins in font-size-adjust-012 and -013 to avoid exceeding the valid test area. r=#style

And revert WPT metadata change from da1d83c060 as the font-size-adjust-013 test does not currently pass,
once all parts of the test are back within the reftest area.

(A recent change from Chrome increased the font size used in this test, but this made it start
unexpectedly "passing" for us because the last pair of test glyphs fell outside the reftest
captured area.)

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1708240 - Fix incorrect WPT expectations for computed value of font-size-adjust with from-font keyword. r=#style

The spec says that from-font computes to a number based on the first available font,
so the currnet test is bogus.

https://drafts.csswg.org/css-fonts-5/#valdef-font-size-adjust-from-font

Depends on D182448

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1708240 - Remove the layout.css.font-size-adjust.basis.enabled pref, as this has been shipping by default for a couple years. r=#style

I don't think there's any reason to keep this pref around; let's just clean it up.

Depends on D182449

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1708240 - Implement the from-font keyword for CSS font-size-adjust. r=#style

Depends on D182450

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1708240 - Add a WPT reftest to check that from-font is resolved using metrics of the current element's font, not the parent's. r=#style

Depends on D182451

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c808970af5
Adjust margins in font-size-adjust-012 and -013 to avoid exceeding the valid test area. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e766d2a9180e
Fix incorrect WPT expectations for computed value of font-size-adjust with from-font keyword. r=emilio
https://hg.mozilla.org/integration/autoland/rev/eac4b88ab28d
Remove the layout.css.font-size-adjust.basis.enabled pref, as this has been shipping by default for a couple years. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e686e061b8b5
Implement the from-font keyword for CSS font-size-adjust. r=emilio
https://hg.mozilla.org/integration/autoland/rev/695203c0ff61
Add a WPT reftest to check that from-font is resolved using metrics of the current element's font, not the parent's. r=emilio

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 5 changesets (Bug 1708240) for causing failures in test_css-properties-db.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=LlyUCbYoTSutZ5zlF2N5fg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=695203c0ff61f346ac85d41599c5e99fe9379ce5&searchStr=xpc

Log: https://treeherder.mozilla.org/logviewer?job_id=424510407&repo=autoland&lineNumber=4584

Backout: https://hg.mozilla.org/integration/autoland/rev/0213f09b86096158f0331bd77d8fe9a8a3a38189

Comment 9

[Jonathan Kew [:jfkthame]]

Ah - missed running mach devtools-css-db. :( Updated the patch.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e53660f7575
Adjust margins in font-size-adjust-012 and -013 to avoid exceeding the valid test area. r=emilio
https://hg.mozilla.org/integration/autoland/rev/042666e7ff9e
Fix incorrect WPT expectations for computed value of font-size-adjust with from-font keyword. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7e72f10cf94c
Remove the layout.css.font-size-adjust.basis.enabled pref, as this has been shipping by default for a couple years. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4148a3755a1e
Implement the from-font keyword for CSS font-size-adjust. r=emilio,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/8e6d6287c0af
Add a WPT reftest to check that from-font is resolved using metrics of the current element's font, not the parent's. r=emilio

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4e53660f7575
https://hg.mozilla.org/mozilla-central/rev/042666e7ff9e
https://hg.mozilla.org/mozilla-central/rev/7e72f10cf94c
https://hg.mozilla.org/mozilla-central/rev/4148a3755a1e
https://hg.mozilla.org/mozilla-central/rev/8e6d6287c0af

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41273 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Dipika]

MDN doc updates for this feature can be tracked through this GitHub issue: https://github.com/mdn/content/issues/28842

Comment 16

[Dipika]

Attachment: font-size-adjust property values in Developer Tools (Nightly 119)

Hello, I have a question - in Web Developer Tools, Styles inspector, the font-size-adjust property is missing ex-height in the list of values (as seen in Nightly 119). Is this intentional?

Comment 17

[Jonathan Kew [:jfkthame]]

Hmm -- I guess that's related to ex-height being the default metric, which can be omitted when specifying the value (so font-size-adjust: 0.5 means exactly the same as font-size-adjust: ex-height 0.5, and serialization will always omit it). But we should expose it in the list here anyhow, as it is valid syntax.

It looks to me like just adding an annotation here should fix this; I'll check in a local build.

Comment 18

[Dipika]

Thanks!