1708289 - Implement AllowFileSelectionDialogs policy on Chrome

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

Chrome has a policy to disable the file dialogs.

This is important Windows especially because with the file dialogs, you can get to system commands.

On Chrome, the Ctrl+S/Ctrl+O just do nothing.

Any save as items are disabled.

When clicking the file dialog on a web page, an infobar displays that says "Access to local files on your machine is disabled by your administrator"

This blocks ALL file dialog, so we would block in the file picker as well just in case.

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1708289 - Implement AllowFileSelectionDialogs policy r?emilio!,mkaply!,gijs!

Comment 2

[Mike Kaply [:mkaply]]

Hey Greg, was wondering if this was still going to happen. Appreciate all you do.

Comment 3

[Gregory Pappas [:gregp]]

Hi Mike! Yes I'd like to finish this. Originally, I paused work on this because I thought that the changes to nsBaseFilePicker in bug 1811076 were going to land soon and I didn't want to have to rebase.

Comment 4

[Gregory Pappas [:gregp]]

Attachment: Bug 1708289 - Implement AllowFileSelectionDialogs policy

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3499edf7911e
Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3499edf7911e

Comment 7

[Mike Kaply [:mkaply]]

Greg, would you mind checking how easy it would be to backport this to the ESR?

Comment 8

[Gregory Pappas [:gregp]]

This patch almost applies cleanly to ESR, backporting it would be very easy. Note that for the best user experience (bug 1878336), we'd want bug 1878401 as well, which would be very, very hard to backport to ESR. Also, I have more patches I will soon post that that further improve the behavior of this policy (Printing to PDF, Library, Page Info window).

All of my follow-ups depend on bug 1878401, so we won't be able to get them into the current ESR. If you're fine with this, I should be able to post a version of this patch that applies cleanly to ESR later today (can't now because I'm at school).

Comment 9

[Mike Kaply [:mkaply]]

I'm fine with that. This gets us the basic functionality on the current ESR and we'll get the rest on the next ESR.

Appreciate all you do!

Comment 10

[Gregory Pappas [:gregp]]

Attachment: WIP: Bug 1708289 - Implement AllowFileSelectionDialogs policy

Comment 11

[Gregory Pappas [:gregp]]

Attachment: Bug 1708289 - Implement AllowFileSelectionDialogs policy

Original Revision: https://phabricator.services.mozilla.com/D203517

Comment 12

[Gregory Pappas [:gregp]]

This patch almost applies cleanly to ESR, backporting it would be very easy.

Actually, applying cleanly doesn't mean the patch will work :)

So, it turns out I completely forgot that this patch depends on changes introduced in bug 1872179. It wouldn't be hard to fish out just the BrowsingContext plumbing stuff from bug 1872179, but that will mean uplifting a much larger change to ESR than I originally thought. Are we comfortable with that?

Comment 13

[Mike Kaply [:mkaply]]

I think we'll not worry about it then.

Thanks for trying!