1708297 - Update share icons

Status: RESOLVED FIXED

(Firefox :: Theme, task, P1)

Description

[Harry Twyford]

These icons used to be used in the page action menu. The macOS share icon is still used in the Touch Bar. It doesn't hurt to update the Windows icon while I'm at it, seeing as we have a new icon for it.

Comment 1

[Harry Twyford]

Attachment: Bug 1708297 - Update share icons. r?sfoster,#mac-reviewers

Tagging mac-reviewers since the only place either of these icons are used anymore is in the Touch Bar.

Comment 2

[Harry Twyford]

[Tracking Requested - why for this release]:
Proton icons.

I'll request uplift tomorrow after verifying in Nightly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64e44a2a6b5b
Update share icons. r=sfoster,mac-reviewers,bradwerth

Comment 4

[Harry Twyford]

The macOS share icon appears in the MacBook Pro Touch Bar. The Windows share icon does not currently appear anywhere.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/64e44a2a6b5b

Comment 6

[Harry Twyford]

Comment on attachment 9219054 [details]
Bug 1708297 - Update share icons. r?sfoster,#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Proton icons will be missing.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changes the contents of two SVGs.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9219054 [details]
Bug 1708297 - Update share icons. r?sfoster,#mac-reviewers

Approved for 89 beta 7, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/816b065c7eb5