1708334 - Find bar has dark text on dark background on third party theme

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[mmis1000]

Attachment: FindBar.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. enable mac system dark mode (?)
2. install this theme https://addons.mozilla.org/zh-TW/firefox/addon/miku-hatsune-omega-clean/
3. cmd + f to search text in some page

Actual results:

You have black text on black background in find bar, make it completely unusable.

Expected results:

The find bar should have a light background (as it used to be).
Or the text should be forced to be white (so you can see text).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Find Toolbar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Yes, I have this too, on the "Firefox Quantum Nightly" theme: https://addons.mozilla.org/en-US/firefox/addon/firefox-quantum-nightly/

Comment 3

[mmis1000]

Attachment: Findbar on my mac has a broken background

Comment 4

[mmis1000]

Attachment: Findbar on my win 10 has a default background

Comment 5

[mmis1000]

seems caused by a missing line in osx theme

The

  --toolbar-non-lwt-bgcolor: -moz-dialog;

did not exist for some reason

https://hg.mozilla.org/mozilla-central/file/tip/browser/themes/windows/browser.css#l13
https://hg.mozilla.org/mozilla-central/file/tip/browser/themes/osx/browser.css#l11

Comment 6

[mmis1000]

Diff suggests broke by this
https://hg.mozilla.org/mozilla-central/rev/8fd0175a750a2ab43bacf390105834571cfcb7e8

Comment 7

[Mike de Boer [:mikedeboer]]

Emma has updated the findbar theme(s) most recently; Emma, do you have a chance perhaps to take a look at this?

Comment 8

[Peter deHaan [:pdehaan]]

Attachment: cmd+F (macOS dark mode)

Comment 9

[Emma Malysz]

Attachment: Bug 1708334, specify toolbar-non-lwt-bgcolor for macos

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59f2374b032c
specify toolbar-non-lwt-bgcolor for macos r=jaws

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/59f2374b032c

Comment 12

[Shilpa Mohanty]

This is a small CSS change, request for uplift.

Comment 13

[Emma Malysz]

Comment on attachment 9220399 [details]
Bug 1708334, specify toolbar-non-lwt-bgcolor for macos

Beta/Release Uplift Approval Request

• User impact if declined: 1708334
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple css fix
• String changes made/needed: n/a

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9220399 [details]
Bug 1708334, specify toolbar-non-lwt-bgcolor for macos

Low risk MR1 fix, approved for 89 beta 10, thanks.

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a0f800971584

Comment 16

[Hani Yacoub, Desktop QA]

Verified as fixed on macOS 10.14 and on macOS 10.15.