1708339 - uninitalised member in nsDMABufDevice

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Paul Bone [:pbone]]

A member is uninitalised in nsDMABufDevice, this was identified by Coveritly:

---

*** CID 1467668: Uninitialized members (UNINIT_CTOR)
/widget/gtk/DMABufLibWrapper.cpp: 185 in mozilla::widget::nsDMABufDevice::nsDMABufDevice()()
179 wl_display* display = WaylandDisplayGetWLDisplay();
180 mRegistry = (void*)wl_display_get_registry(display);
181 wl_registry_add_listener((wl_registry*)mRegistry, &registry_listener, this);
182 wl_display_roundtrip(display);
183 wl_display_roundtrip(display);
184 }

CID 1467668:  Uninitialized members  (UNINIT_CTOR)
Non-static class member "mRegistry" is not initialized in this constructor nor in any functions that it calls.

185 }
186
187 nsDMABufDevice::~nsDMABufDevice() {
188 if (mRegistry) {
189 wl_registry_destroy((wl_registry*)mRegistry);
190 mRegistry = nullptr;

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1708339 - Always initalise nsDMABufDevice::mRegistry r=stransky

This was only initialised if the if branch was entered in the constructor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f79cf8568e7
Always initalise nsDMABufDevice::mRegistry r=stransky

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7f79cf8568e7