1708428 - [Proton] New Folder button (Bookmark panel) does not apply the specific proton dark theme

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshot issue.png

Affected versions

• 89.0b5
• 90.0a1 (2021-04-28)

Affected platforms

• Windows 10

Steps to reproduce

1. Set the dark theme
2. Open any website
3. Click the Star icon inside the URL bar
4. Click the dropdown arrow (Show all the bookmarks folders)
5. Highlight the New Folder button

Expected result

• The focus highlight is dark theme specific

Actual result

• The focus highlight is stuck with the light theme one

Regression range

• Introduced with the Proton changes

Comment 1

[Tyler Duzan]

Interesting, I wonder if this is any way related to the issue I noticed in my PM review on macOS. In this panel, I see a few issues, but they all are related to parts of the panel not being dark themed, essentially. I don't think this will make a fix in 89, but I think we should try to fix this for 90.

Comment 2

[Molly Howell (she/her) (no longer active)]

That button just didn't get the Proton memo at all, huh. We can fix that.

Tyler, what were the other dark theme issues you had identified, and do you know if there are bugs filed for them? I notice that the folder tree and the tags list are not dark, but that should be a separate bug.

Comment 3

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1708428 - Apply Proton styling to the edit bookmark panel's New Folder button. r=#desktop-theme-reviewers

These styles were copied from the popupnotification's .panel-footer > button
CSS, with a couple of adjustments which have comments here, and skipping over
the disabled styles because this button is never disabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d4b78379fda
Apply Proton styling to the edit bookmark panel's New Folder button. r=desktop-theme-reviewers,harry

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7d4b78379fda

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[Anca Soncutean, Desktop QA]

Verified fixed with latest Nightly (2021-07-29) on Windows 10 and macOS 11.0.