1708451 - [Proton] The highlight on "Don't save" button from the Save login panel is not correctly displayed

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Oana Botisan, Desktop QA]

Attachment: image.png

Affected versions

• Firefox 89.0b5
• Firefox 90.0a1

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64

Steps to reproduce

1. Go to facebook.com.
2. Write credential in the fields and click in "Log In".
3. Navigate the login panel using keyboard.

Expected result

• The highlight on "Don't save" button is correctly displayed.

Actual result

• The highlight on "Don't save" button is not correctly displayed.

Regression range

• First bad: 2021-04-09
• Last good: 2021-04-08
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=83a21ab93aff939d348468e69249a3a33ccfca88&tochange=7bc2dd06085f53993037b4fc78ee651c5afc7671

Additional notes

• Please look at the attached image.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Spec screenshot

Hi Oana,

I'm confused - this looks like it's per spec, but am I missing something? Which part of the highlight is wrong?

Comment 2

[Oana Botisan, Desktop QA]

Attachment: image (2).png

That was the issue... it looked like a bug, especially because the highlight on the arrow looks different, cleaner.
We didn't see the specs for this part. Can you please provide us with a link to this? Thank you.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Okay, redirecting to KatieC. The focus ring looks to spec to me, but let's double-check that the spec is supposed to show a difference between the left-part of the split button and the right.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I spoke to KatieC about this. While it's true we're to the Figma spec here, the intention was to have the focus ring be a uniform width around the left side of the split button.

So this is a legitimate bug.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1708451 - Temporarily boost z-index of main part of splitbutton when showing its focus ring. r?Itiel!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eacb24786032
Temporarily boost z-index of main part of splitbutton when showing its focus ring. r=Itiel,desktop-theme-reviewers

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/eacb24786032

Comment 8

[Oana Botisan, Desktop QA]

I verified the fix using latest Nightly 90.0a1 on Windows 10 x64 and Ubuntu 18.04 x64. The issue is not reproducing anymore.