[Proton] The highlight on "Don't save" button from the Save login panel is not correctly displayed
Categories
(Toolkit :: Password Manager, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | wontfix |
firefox90 | --- | verified |
People
(Reporter: oana.botisan, Assigned: mconley)
References
(Blocks 2 open bugs)
Details
(Keywords: regression, Whiteboard: [proton-door-hangers] [priority:2b])
Attachments
(4 files)
Affected versions
- Firefox 89.0b5
- Firefox 90.0a1
Affected platforms
- Windows 10 x64
- Ubuntu 18.04 x64
Steps to reproduce
- Go to facebook.com.
- Write credential in the fields and click in "Log In".
- Navigate the login panel using keyboard.
Expected result
- The highlight on "Don't save" button is correctly displayed.
Actual result
- The highlight on "Don't save" button is not correctly displayed.
Regression range
- First bad: 2021-04-09
- Last good: 2021-04-08
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=83a21ab93aff939d348468e69249a3a33ccfca88&tochange=7bc2dd06085f53993037b4fc78ee651c5afc7671
Additional notes
- Please look at the attached image.
Assignee | ||
Comment 1•2 years ago
|
||
Hi Oana,
I'm confused - this looks like it's per spec, but am I missing something? Which part of the highlight is wrong?
Assignee | ||
Updated•2 years ago
|
Reporter | ||
Comment 2•2 years ago
•
|
||
That was the issue... it looked like a bug, especially because the highlight on the arrow looks different, cleaner.
We didn't see the specs for this part. Can you please provide us with a link to this? Thank you.
Assignee | ||
Comment 3•2 years ago
|
||
Okay, redirecting to KatieC. The focus ring looks to spec to me, but let's double-check that the spec is supposed to show a difference between the left-part of the split button and the right.
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
I spoke to KatieC about this. While it's true we're to the Figma spec here, the intention was to have the focus ring be a uniform width around the left side of the split button.
So this is a legitimate bug.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eacb24786032 Temporarily boost z-index of main part of splitbutton when showing its focus ring. r=Itiel,desktop-theme-reviewers
Comment 7•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Reporter | ||
Comment 8•2 years ago
|
||
I verified the fix using latest Nightly 90.0a1 on Windows 10 x64 and Ubuntu 18.04 x64. The issue is not reproducing anymore.
Description
•