Closed
Bug 1708457
Opened 5 years ago
Closed 5 years ago
Don't return a Promise in Inspector#_destroyMarkup
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox90 fixed)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
In https://searchfox.org/mozilla-central/rev/49e0a928390a8013a4eb08b7b3bbff025f01913a/devtools/client/inspector/inspector.js#1742-1757 , we return Promises in different places, but we shouldn't as MarkupView#destroy does not return a Promise + none of the callsites actually do anything with its return value
|
Assignee | |
Comment 1•5 years ago
|
||
MarkupView#destroy is synchronous, so there's no need for _destroyMarkup to return
a Promise.
The different callsites don't do anything with the returned value so there's nothing
more to cleanup.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf053d5617a4
[devtools] Don't return a Promise in Inspector#_destroyMarkup. r=jdescottes.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•