Closed Bug 1708533 Opened 7 months ago Closed 7 months ago

Proton: Search mode close "X" is bigger than design

Categories

(Firefox :: Address Bar, defect, P2)

Desktop
All
defect
Points:
1

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox88 --- disabled
firefox89 + verified
firefox90 --- verified

People

(Reporter: pablo.muir, Assigned: harry)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-address-bar] [priority:2b] [proton-uplift])

Attachments

(3 files)

Attached image image.png

Affected versions
89.0b5 beta
90.0a1 nightly

Affected platforms
Ubuntu 20 64bit , win10 64bit, MacOS 10.14

Preconditions
Proton ON (by default on nightly and beta)

Steps to reproduce
-open new tab
-click on a one off , example.. duckduckgo
-check the "X" on search mode

Actual result
The X is bigger than figma design

Expected result
the X (close) should be smaller.

Whiteboard: [proton-address-bar]

Hi romain, could you please set a priority for bug?
thanks!

Flags: needinfo?(rtestard)
Severity: -- → S4
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 90.1 - Apr 19 - May 2
Points: --- → 1
Flags: needinfo?(rtestard)
Priority: -- → P2
Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2b]

[Tracking Requested - why for this release]:
Proton sizing issue. Two-line CSS fix.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0773d38e9bb4
Shrink search mode close button. r=mak
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(htwyford)

Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Proton style issue; an element in the address bar will be noticeably too big.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Three-line CSS fix; well-understood; tightly scoped.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9219335 - Flags: approval-mozilla-beta?
Whiteboard: [proton-address-bar] [priority:2b] → [proton-address-bar] [priority:2b] [proton-uplift]

Harry , i checked nightly 90.0a1 on Mac 10.14, ubuntu 20 and Mac0S 10.14 now the x is smaller.
but first i thought the x was too high but it ended up being the letters being too low.

do you want me to log a new bug for this? (screenshot attached when checking on windows10)

Flags: needinfo?(htwyford)
Attached image Xonmode.jpg

there's already a bug for the text being low, see Bug 1705723

Flags: needinfo?(htwyford)

Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers

Low risk, approved for 89 beta 8, thanks.

Attachment #9219335 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.