1708533 - Proton: Search mode close "X" is bigger than design

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Pablo]

Attachment: image.png

Affected versions
89.0b5 beta
90.0a1 nightly

Affected platforms
Ubuntu 20 64bit , win10 64bit, MacOS 10.14

Preconditions
Proton ON (by default on nightly and beta)

Steps to reproduce
-open new tab
-click on a one off , example.. duckduckgo
-check the "X" on search mode

Actual result
The X is bigger than figma design

Expected result
the X (close) should be smaller.

Comment 1

[Pablo]

Hi romain, could you please set a priority for bug?
thanks!

Comment 2

[Harry Twyford]

Attachment: Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers

Comment 3

[Harry Twyford]

[Tracking Requested - why for this release]:
Proton sizing issue. Two-line CSS fix.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0773d38e9bb4
Shrink search mode close button. r=mak

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0773d38e9bb4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Harry Twyford]

Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Proton style issue; an element in the address bar will be noticeably too big.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Three-line CSS fix; well-understood; tightly scoped.
• String changes made/needed:

Comment 8

[Pablo]

Harry , i checked nightly 90.0a1 on Mac 10.14, ubuntu 20 and Mac0S 10.14 now the x is smaller.
but first i thought the x was too high but it ended up being the letters being too low.

do you want me to log a new bug for this? (screenshot attached when checking on windows10)

Comment 9

[Pablo]

Attachment: Xonmode.jpg

Comment 10

[Marco Bonardo [:mak]]

there's already a bug for the text being low, see Bug 1705723

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers

Low risk, approved for 89 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/392856f25322

Comment 13

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8