Closed Bug 1708543 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 28748 - Replace int2byte from six with string literals or bytes(...)

Categories

(Core :: DOM: Networking, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28748 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28748
Details from upstream follow.

b'Philip J\xc3\xa4genstedt <philip@foolip.org>' wrote:

Replace int2byte from six with string literals or bytes(...)

The following expressions were evaluated as True in a Python 3.8.2 shell
to gain confidence:

from six import int2byte
b"".join(int2byte(byte) for byte in range(255)) == bytes(range(255))
int2byte(0xff) == b"\xff"
int2byte(0x83) + int2byte(0x65) + int2byte(0x83) + int2byte(0x58) + int2byte(0x83) + int2byte(0x67) == bytes([0x83, 0x65, 0x83, 0x58, 0x83, 0x67])
b'<' + int2byte(0xff) + b'/>' == b'<\xff/>'
Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 168 subtests

Status Summary

Firefox

OK : 5
PASS: 514

Chrome

OK : 5
PASS: 514

Safari

OK : 5
PASS: 514

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c06c785f040c [wpt PR 28748] - Replace int2byte from six with string literals or bytes(...), a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.