1708558 - Update the icons in the library/places UI

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: image(1).png

We have a mix of icon styles in the places dialog. We have newly drawn icons that could be used to replace most of those not already updated.

Details on which icons to use, where to get them and how to go about it are in this document: https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE

Comment 1

[Micah [:mtigley] (she/her)]

Sam it looks like we're missing new icons for:

• https://searchfox.org/mozilla-central/source/browser/themes/shared/places/folder-smart.svg
• https://searchfox.org/mozilla-central/source/browser/themes/shared/places/bookmarksToolbar.svg
• https://searchfox.org/mozilla-central/source/browser/themes/shared/places/bookmarksMenu.svg
• https://searchfox.org/mozilla-central/source/browser/themes/shared/places/tag.svg

Are these ones out of scope?

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1708558 - Update history icon in library window. r?sfoster

Comment 3

[Micah [:mtigley] (she/her)]

Just checked the spreadsheet, looks like there are no plans for the above icons.

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Micah Tigley [:mtigley] from comment #3)

Just checked the spreadsheet, looks like there are no plans for the above icons.

Yeah this UI surface was out of scope for the icon redesign, so we end up in this mixed state as some got updates by virtue of being used elsewhere, and others did not. So I don't think there's harm in updating history.svg here, but its not going to be possible to fix them all at this point.

Comment 5

[Micah [:mtigley] (she/her)]

For QA: the updated history icon can be checked at the following places:

• Library window under the "History" tree view: open the window using cmd+shift+O (on Mac) or ctrl+shift+o (on Windows)
• The "History" toolbarbutton that can be added from the customize palette
• The "History" search shortcut under the URLbar dropdown
• about:preferences#search under the "Search Shortcuts" section

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7678ffdd97f7
Update history icon in library window. r=sfoster,desktop-theme-reviewers,harry

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7678ffdd97f7

Comment 8

[Romain Testard [:RT]]

Confirming here that we (UX and PM) want this uplifted for MR1 to Beta.

Comment 9

[Micah [:mtigley] (she/her)]

Comment on attachment 9220193 [details]
Bug 1708558 - Update history icon in library window. r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 5
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial icon change
• String changes made/needed:

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9220193 [details]
Bug 1708558 - Update history icon in library window. r?sfoster

Low risk, approved for 89 beta 10, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/531fcc1e1f18

Comment 12

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 90.0a1 (20210506214311) and 89.0b10 (20210507073536) from comment 11 on Windows 10x64, macOS 11 and Ubuntu 20. The History icon is displayed inside the Library window. Also checked other places from comment 5 as well.