Closed Bug 1708589 Opened 3 years ago Closed 3 years ago

Vertical alignment of blocked popup icon in URL bar could be improved

Categories

(Firefox :: Site Permissions, defect, P2)

Product:
Firefox
Component:
Site Permissions
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-icons] [proton-uplift])

Attachments

(3 files)

image.png
6.28 KB, image/png
Details
Bug 1708589 - Improve vertical alignment of blocked popup icon in URL bar. r?harry!
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
After patch applied
5.13 KB, image/png
Details
Attached image image.png —

Due to how the blocked popup icon is placed within its SVG file, it appears slightly offset vertically from other icons that can appear with it within the URL bar.

This patch uses CSS to nudge it slightly to make it more aesthetically pleasing.

Attached image After patch applied —
Blocks: proton-icons
Severity: -- → S4
status-firefox88: --- → unaffected
status-firefox89: --- → affected
status-firefox90: --- → affected
status-firefox-esr78: --- → unaffected
Priority: -- → P2
Regressed by: 1702837
Has Regression Range: --- → yes
Blocks: 1708716
See Also: → https://jira.mozilla.com/browse/FIDEFE-1567
Whiteboard: [proton-icons]
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a54df3fe00b
Improve vertical alignment of blocked popup icon in URL bar. r=harry,desktop-theme-reviewers,mak

https://hg.mozilla.org/mozilla-central/rev/7a54df3fe00b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mconley)

Comment on attachment 9219408 [details]
Bug 1708589 - Improve vertical alignment of blocked popup icon in URL bar. r?harry!

Beta/Release Uplift Approval Request

  • User impact if declined: A Proton icon that appears in the URL bar might appear misaligned.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This adds a single CSS rule that bumps the one icon just a few pixels vertically. It's very simple and well-understood.
  • String changes made/needed: None.
Flags: needinfo?(mconley)
Attachment #9219408 - Flags: approval-mozilla-beta?
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]
Attachment #9219408 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: