1708591 - eslint python unit test busts the tree for subsequent tasks on the same worker

Status: NEW

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mike Hommey [:glandium]]

It leaves the source in a state that hg robustcheckout --purge in a subsequent task can't get out of and fails with e.g.:

[vcs 2021-04-30T01:26:25.241Z] (purging working directory)
[vcs 2021-04-30T01:26:25.241Z] build\src\build\src\node_modules\eslint-plugin-spidermonkey-js: The system cannot find the path specified
[vcs 2021-04-30T01:26:25.244Z] build\src\build\src\node_modules\eslint-plugin-mozilla: The system cannot find the path specified
[vcs 2021-04-30T01:26:27.151Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "pull", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 17.0}, {"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "purge_errored", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 3.436999797821045}, {"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "overall", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 27.566999912261963}, {"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "overall_pull", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 27.566999912261963}, {"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "overall_pull_fullcheckout", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 27.566999912261963}, {"extraOptions": ["c5.2xlarge"], "hgVersion": "4.7.1", "lowerIsBetter": true, "name": "overall_pull_populatedwdir", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 27.566999912261963}]}
[vcs 2021-04-30T01:26:27.152Z] Traceback (most recent call last):
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\scmutil.pyc", line 161, in callcatch
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\dispatch.pyc", line 344, in _runcatchfunc
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\dispatch.pyc", line 984, in _dispatch
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\dispatch.pyc", line 730, in runcommand
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\dispatch.pyc", line 992, in _runcommand
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\dispatch.pyc", line 981, in <lambda>
[vcs 2021-04-30T01:26:27.152Z]   File "mercurial\util.pyc", line 1528, in check
[vcs 2021-04-30T01:26:27.152Z]   File "C:/mozilla-build/robustcheckout.py", line 185, in robustcheckout
[vcs 2021-04-30T01:26:27.152Z]   File "C:/mozilla-build/robustcheckout.py", line 644, in _docheckout
[vcs 2021-04-30T01:26:27.152Z]   File "hgext\purge.pyc", line 126, in purge
[vcs 2021-04-30T01:26:27.152Z] WindowsError: [Error 3] The system cannot find the path specified: 'Z:\\task_1619745394\\build\\src\\node_modules/eslint-plugin-spidermonkey-js/*.*'
[vcs 2021-04-30T01:26:27.152Z] abort: The system cannot find the path specified: 'Z:\task_1619745394\build\src\node_modules/eslint-plugin-spidermonkey-js/*.*'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1708591 - Disable test_eslint.py on Windows.

Comment 2

[Mike Hommey [:glandium]]

The attached patch only papers over the problem. It will stil need to be fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/344765f21873
Disable test_eslint.py on Windows. r=sylvestre

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/344765f21873

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:ahal, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 7

[Andrew Halberstadt [:ahal]]

Still valid.